You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/10/10 10:05:30 UTC
[GitHub] [incubator-echarts] plainheart opened a new issue #13417: [5.0] The state of `toolbox` will be changed to `normal` after the series leaves emphasis.
plainheart opened a new issue #13417:
URL: https://github.com/apache/incubator-echarts/issues/13417
### Version
The current next branch
### Steps to reproduce
Any cases with `toolbox`.
For example, `test/toolbox-stack-custom.html`
### What is actually happening?
The state of the `toolbox` component was changed to `normal`.
### What is expected?
The emphasis state of the `toolbox` component should be kept.
### Others
I looked around and found it might be caused by the following code.
https://github.com/apache/incubator-echarts/blob/next/src/util/states.ts#L367-L378
According to the PR #12925, I think the `blur` state is supported in all series. But is it also supported in all components?
If not, perhaps we should only traverse the series and exclude the components like `toolbox`, `axis` etc..
**Proposed changes**
```js
// Before
// model.eachComponent(function (componentType, componentModel) {
// const view = componentType === 'series'
// ? ecIns.getViewOfSeriesModel(componentModel as SeriesModel)
// : ecIns.getViewOfComponentModel(componentModel);
// // Leave blur anyway
// view.group.traverse(function (child) {
// singleLeaveBlur(child);
// });
// });
// After
model.eachSeries(function (seriesModel) {
const view = ecIns.getViewOfSeriesModel(seriesModel);
// Leave blur anyway
view.group.traverse(function (child) {
singleLeaveBlur(child);
});
});
```
I'm not sure, these are only my simple thoughts.
Thanks.
<!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
<!-- This issue is in English. DO NOT REMOVE -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart commented on issue #13417: [5.0] The state of `toolbox` will be changed to `normal` after the series leaves emphasis.
Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #13417:
URL: https://github.com/apache/incubator-echarts/issues/13417#issuecomment-708958130
It works well now. Thank you for the fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart commented on issue #13417: [5.0] The state of `toolbox` will be changed to `normal` after the series leaves emphasis.
Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #13417:
URL: https://github.com/apache/incubator-echarts/issues/13417#issuecomment-706524666
@pissang I've left some thoughts on this bug. Please help to check and fix it if possible. Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang edited a comment on issue #13417: [5.0] The state of `toolbox` will be changed to `normal` after the series leaves emphasis.
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on issue #13417:
URL: https://github.com/apache/incubator-echarts/issues/13417#issuecomment-706531793
@plainheart Thanks for the detailed feedback. Some components like `geo` have `blur` and `select` states. So the code is to apply these states if component support. But toolbox is not supposed to be affected. I will look into it and fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] plainheart closed issue #13417: [5.0] The state of `toolbox` will be changed to `normal` after the series leaves emphasis.
Posted by GitBox <gi...@apache.org>.
plainheart closed issue #13417:
URL: https://github.com/apache/incubator-echarts/issues/13417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13417: [5.0] The state of `toolbox` will be changed to `normal` after the series leaves emphasis.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #13417:
URL: https://github.com/apache/incubator-echarts/issues/13417#issuecomment-706524141
Hi! We've received your issue and please be patient to get responded. 🎉
The average response time is expected to be within one day for weekdays.
In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer.
If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical questions.
If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html).
Have a nice day! 🍵
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on issue #13417: [5.0] The state of `toolbox` will be changed to `normal` after the series leaves emphasis.
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #13417:
URL: https://github.com/apache/incubator-echarts/issues/13417#issuecomment-706531793
@plainheart Noticed that too. Some components like `geo` have `blur` and `select` states. So the code is to apply these states if component support. But toolbox is not supposed to be affected. I will look into it and fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org