[GitHub] [superset] villebro commented on pull request #22238: fix(generic-chart-axes): apply time filter on all target column types

[GitBox <gi...@apache.org>]

villebro commented on PR #22238:
URL: https://github.com/apache/superset/pull/22238#issuecomment-1328872103

   > Thanks for the fixing! I would suggest that move the `filter_values_handler` method into a helper module and then refactoring it in the future. BTW, we should find out an approach to conversion column type.
   
   My thoughts exactly - I have an idea of how to get this cleanup started, I'll try to open a PR later in the week.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org