You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Antoine Pitrou (Jira)" <ji...@apache.org> on 2019/09/17 16:58:00 UTC
[jira] [Updated] (ARROW-6515) [C++] Remove IsSignedInt trait
[ https://issues.apache.org/jira/browse/ARROW-6515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Pitrou updated ARROW-6515:
----------------------------------
Fix Version/s: 1.0.0
> [C++] Remove IsSignedInt trait
> ------------------------------
>
> Key: ARROW-6515
> URL: https://issues.apache.org/jira/browse/ARROW-6515
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Benjamin Kietzman
> Assignee: Benjamin Kietzman
> Priority: Major
> Fix For: 1.0.0
>
>
> {{IsSignedInt}} takes either an array or a type as a type argument, which is surprisingly atypical for traits. Furthermore whereas {{is_signed_integer}} returns false for date and other types which are represented by but not identical to integers {{IsSignedInt}} returns true by checking only the {{c_type}}, which leads to {{static_assert(IsSignedInt<HalfFloatType>::value, "")}}. Finally the declaration of {{IsSignedInt}} is far from readable due to nested macro usage.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)