You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/01/07 12:33:33 UTC

[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #1235: MINIFICPP-1710,MINIFICPP-1714 Stabilize docker tests

lordgamez opened a new pull request #1235:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1235


   Recently some docker tests were failing randomly in CI in the OPC and Kafka test suites. The root cause for both suite failures was the same that NiFi's and MiNiFi's PutFile processor creates a hidden temporary file before renaming it to the final version when all content has been written. The scheduling of the threads can cause that the temp file can be non-existent anymore when it is read or causes a premature notification of the file output creation. These files should be ignored in the notification and the output verification process.
   
   This fix also revealed a flakiness of the ListS3 test due to a timing issue of the creation and the listing of S3 objects. The test was also refactored to be more stable.
   
   https://issues.apache.org/jira/browse/MINIFICPP-1710
   https://issues.apache.org/jira/browse/MINIFICPP-1714
   
   ------------------------------------------------------------
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1235: MINIFICPP-1710,MINIFICPP-1714 Stabilize docker tests

Posted by GitBox <gi...@apache.org>.
szaszm closed pull request #1235:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1235


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org