You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/15 20:07:57 UTC
[GitHub] [incubator-superset] RohitK89 opened a new pull request #7303: Add
version info, github and documentation buttons back into the navbar
RohitK89 opened a new pull request #7303: Add version info, github and documentation buttons back into the navbar
URL: https://github.com/apache/incubator-superset/pull/7303
### CATEGORY
Choose one
- [ ] Bug Fix
- [ x ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Adds back the buttons for version info, Github repo and documentation into the navbar.
These were removed sometime between 0.26.3 and 0.28.1.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="404" alt="Screen Shot 2019-04-15 at 3 58 00 PM" src="https://user-images.githubusercontent.com/8096320/56161830-8efb1c80-5f98-11e9-94ad-04c0d563281b.png">
After:
<img width="369" alt="Screen Shot 2019-04-15 at 4 01 32 PM" src="https://user-images.githubusercontent.com/8096320/56161849-96bac100-5f98-11e9-9e9d-eedcd1acc5b8.png">
### TEST PLAN
Start up webserver and look for version, github and documentation buttons in the navbar on the right
### ADDITIONAL INFORMATION
- [ x ] Has associated issue: Fixes #6992
- [ x ] Changes UI
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org