[GitHub] [accumulo] ivakegg commented on a change in pull request #1646: fixes #1644: minor compaction retry

[GitBox <gi...@apache.org>]

ivakegg commented on a change in pull request #1646:
URL: https://github.com/apache/accumulo/pull/1646#discussion_r447937841



##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactor.java
##########
@@ -148,6 +149,13 @@ public CompactionStats call() {
           reportedProblem = true;
         } catch (CompactionCanceledException e) {
           throw new IllegalStateException(e);
+        } catch (Throwable t) {
+          // This is an unexpected situation which is critical. If we cannot minor compact
+          // then this tablet will eventually become unusable if we are still ingesting data.
+          log.error("MinC failed ({}).  Aborting.", t.getMessage(), t);
+          // TODO: Should we simply unload this tablet instead?
+          Halt.halt("Unexpected MinC failure: " + t.getMessage(), 2);
+          throw t;

Review comment:
       Good call.  I will move the halt logic.  The question still remains whether halting is the appropriate action here.  I could try unloading the tablet instead.....




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org