You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Gera Shegalov (JIRA)" <ji...@apache.org> on 2016/07/19 00:33:20 UTC
[jira] [Commented] (HADOOP-12912) Add LOG.isDebugEnabled() guard in
Progress.set method
[ https://issues.apache.org/jira/browse/HADOOP-12912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383375#comment-15383375 ]
Gera Shegalov commented on HADOOP-12912:
----------------------------------------
isDebugEnabled is worth doing for "best practices" reason imo. I just noticed it in a thread dump. It's much more than a branching instruction. there a bunch of invokevirtual in commons and log4j logging and invokeinterface call behind it.
> Add LOG.isDebugEnabled() guard in Progress.set method
> -----------------------------------------------------
>
> Key: HADOOP-12912
> URL: https://issues.apache.org/jira/browse/HADOOP-12912
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Tsuyoshi Ozawa
> Assignee: Tsuyoshi Ozawa
> Attachments: HADOOP-12912.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org