You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/22 09:33:41 UTC
[GitHub] [beam] kamilwu opened a new pull request #11491: [BEAM-8790] InfluxDB deployment
kamilwu opened a new pull request #11491:
URL: https://github.com/apache/beam/pull/11491
First PR that starts an implementation of the proposal: https://s.apache.org/test-metrics-storage-corrected
Instructions on how to deploy InfluxDB to Kubernetes cluster are available in the wiki: https://cwiki.apache.org/confluence/display/BEAM/Test+Results+Monitoring
After this PR is accepted and InfluxDB is deployed, next steps are:
* Create new Grafana dashboards: [BEAM-8134](https://issues.apache.org/jira/browse/BEAM-8134)
* Reporting test results to InfluxDB: [BEAM-8132](https://issues.apache.org/jira/browse/BEAM-8132) and [BEAM-8133](https://issues.apache.org/jira/browse/BEAM-8133)
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Ardagan commented on a change in pull request #11491: [BEAM-8790] InfluxDB deployment
Posted by GitBox <gi...@apache.org>.
Ardagan commented on a change in pull request #11491:
URL: https://github.com/apache/beam/pull/11491#discussion_r416325031
##########
File path: .test-infra/metrics/docker-compose.yml
##########
@@ -44,11 +62,16 @@ services:
- GF_SECURITY_ADMIN_PASSWORD=<GrafanaPasswordHere>
- GF_AUTH_ANONYMOUS_ENABLED=true
- GF_AUTH_ANONYMOUS_ORG_NAME=Beam
- - DB_HOST=beampostgresql
- - DB_PORT=5432
- - DB_DBNAME=beam_metrics
- - DB_DBUSERNAME=admin
- - DB_DBPWD=<PGPasswordHere>
+ - PSQL_DB_HOST=beampostgresql
Review comment:
Minor: should we use "user_metrics_db" and "perftests_metrics_db" instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on issue #11491: [BEAM-8790] InfluxDB deployment
Posted by GitBox <gi...@apache.org>.
kamilwu commented on issue #11491:
URL: https://github.com/apache/beam/pull/11491#issuecomment-617667680
@Ardagan Could you take a look? Also, feel free to tag anyone familiar with Kubernetes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11491: [BEAM-8790] InfluxDB deployment
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11491:
URL: https://github.com/apache/beam/pull/11491#issuecomment-620554033
Thanks @Ardagan. I'm going to merge it right now. We can continue the discussion (https://github.com/apache/beam/pull/11491#discussion_r416325031) in the same place and I'll create a follow-up PR if there are any changes to be applied.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on pull request #11491: [BEAM-8790] InfluxDB deployment
Posted by GitBox <gi...@apache.org>.
kamilwu commented on pull request #11491:
URL: https://github.com/apache/beam/pull/11491#issuecomment-619838765
Run CommunityMetrics PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu commented on a change in pull request #11491: [BEAM-8790] InfluxDB deployment
Posted by GitBox <gi...@apache.org>.
kamilwu commented on a change in pull request #11491:
URL: https://github.com/apache/beam/pull/11491#discussion_r416520744
##########
File path: .test-infra/metrics/docker-compose.yml
##########
@@ -44,11 +62,16 @@ services:
- GF_SECURITY_ADMIN_PASSWORD=<GrafanaPasswordHere>
- GF_AUTH_ANONYMOUS_ENABLED=true
- GF_AUTH_ANONYMOUS_ORG_NAME=Beam
- - DB_HOST=beampostgresql
- - DB_PORT=5432
- - DB_DBNAME=beam_metrics
- - DB_DBUSERNAME=admin
- - DB_DBPWD=<PGPasswordHere>
+ - PSQL_DB_HOST=beampostgresql
Review comment:
Do you mean changing databases names (PSQL_DB_DBNAME and INFLUX_DB_DBNAME) or hostnames (PSQL_DB_HOST and INFLUX_DB_HOST)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kamilwu edited a comment on pull request #11491: [BEAM-8790] InfluxDB deployment
Posted by GitBox <gi...@apache.org>.
kamilwu edited a comment on pull request #11491:
URL: https://github.com/apache/beam/pull/11491#issuecomment-620554033
Thanks @Ardagan. I'm going to merge it right now. We can continue the discussion (https://github.com/apache/beam/pull/11491#discussion_r416325031) at the same place and I'll create a follow-up PR if there are any changes to be applied.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org