You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/07/15 17:42:58 UTC

[GitHub] [couchdb] noahshaw11 opened a new pull request, #4114: Add toggle for smoosh queue persistence

noahshaw11 opened a new pull request, #4114:
URL: https://github.com/apache/couchdb/pull/4114

   ## Overview
   
   This PR adds a toggle to enable and disable the smoosh queue persistence added in https://github.com/apache/couchdb/pull/3766.
   
   ## Testing recommendations
   
   ```
   make eunit apps=smoosh
   ```
   
   ## Related Issues or Pull Requests
   
   Add smoosh queue persistence: https://github.com/apache/couchdb/pull/3766
   
   ## Checklist
   
   - [ ] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] rnewson commented on pull request #4114: Add toggle for smoosh queue persistence

Posted by GitBox <gi...@apache.org>.
rnewson commented on PR #4114:
URL: https://github.com/apache/couchdb/pull/4114#issuecomment-1187063346

   nice :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] nickva commented on a diff in pull request #4114: Add toggle for smoosh queue persistence

Posted by GitBox <gi...@apache.org>.
nickva commented on code in PR #4114:
URL: https://github.com/apache/couchdb/pull/4114#discussion_r922417836


##########
src/smoosh/src/smoosh_channel.erl:
##########
@@ -105,8 +105,9 @@ init(Name) ->
     erlang:send_after(60 * 1000, self(), check_window),
     process_flag(trap_exit, true),
     Waiting = smoosh_priority_queue:new(Name),
+    Persist = config:get_boolean("smoosh", "persist", false),
     State =
-        case smoosh_utils:is_view_channel(Name) of
+        case smoosh_utils:is_view_channel(Name) orelse Persist =:= "false" of

Review Comment:
   `Persist` value would be a boolean so you'd check for `false` or `true`. Could do `not Persist` but `Persist =:= false` might read better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] nickva merged pull request #4114: Add toggle for smoosh queue persistence

Posted by GitBox <gi...@apache.org>.
nickva merged PR #4114:
URL: https://github.com/apache/couchdb/pull/4114


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] nickva commented on a diff in pull request #4114: Add toggle for smoosh queue persistence

Posted by GitBox <gi...@apache.org>.
nickva commented on code in PR #4114:
URL: https://github.com/apache/couchdb/pull/4114#discussion_r922394376


##########
src/smoosh/src/smoosh_channel.erl:
##########
@@ -105,8 +105,9 @@ init(Name) ->
     erlang:send_after(60 * 1000, self(), check_window),
     process_flag(trap_exit, true),
     Waiting = smoosh_priority_queue:new(Name),
+    Persist = config:get("smoosh", "persist", "false"),

Review Comment:
   We could use `config:get_boolean("smoosh", "persist", false)` here I think



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org