You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/05/16 20:24:09 UTC

[GitHub] [accumulo] DomGarguilo opened a new pull request, #2711: Format functions.js

DomGarguilo opened a new pull request, #2711:
URL: https://github.com/apache/accumulo/pull/2711

   This PR changes the formatting of functions.js to conform to the jslint formatting guidelines. 
   
   These changes include:
   * Changing indentation
   * Adding brackets for all if statements
   * Removing else statements where not needed
   * Rearranging resources so they are defined before they are used
   
   No logic in this file should be altered by these changes. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] milleruntime commented on pull request #2711: Format functions.js

Posted by GitBox <gi...@apache.org>.
milleruntime commented on PR #2711:
URL: https://github.com/apache/accumulo/pull/2711#issuecomment-1128768772

   It would be nice if we had something to run once to fix all the indentation on the JS. I will look to see if I can find anything.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] DomGarguilo merged pull request #2711: Format functions.js

Posted by GitBox <gi...@apache.org>.
DomGarguilo merged PR #2711:
URL: https://github.com/apache/accumulo/pull/2711


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] DomGarguilo commented on pull request #2711: Format functions.js

Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on PR #2711:
URL: https://github.com/apache/accumulo/pull/2711#issuecomment-1131696977

   > LGTM. Were you able to use jslint with the indent option?
   
   Yep. I used the command you mentioned earlier, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] DomGarguilo commented on pull request #2711: Format functions.js

Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on PR #2711:
URL: https://github.com/apache/accumulo/pull/2711#issuecomment-1130028486

   > Can this be configured to use 2 space indent? 4 spaces is just excessive.
   
   Addressed in [0f5ffed](https://github.com/apache/accumulo/pull/2711/commits/0f5ffed7987e396c999465b8cce0912615652d8f)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] ctubbsii commented on pull request #2711: Format functions.js

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #2711:
URL: https://github.com/apache/accumulo/pull/2711#issuecomment-1128904394

   > It would be nice if we had something to run once to fix all the indentation on the JS. I will look to see if I can find anything.
   
   Could put a script in contrib/ to do it. Or, make it run with an optional profile during the build and using exec-maven-plugin, if you have a command to do it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] milleruntime commented on pull request #2711: Format functions.js

Posted by GitBox <gi...@apache.org>.
milleruntime commented on PR #2711:
URL: https://github.com/apache/accumulo/pull/2711#issuecomment-1128767813

   FYI It looks like you can specify an option when running `jslint`:
   `npx jslint --indent 2 <file>`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org