[GitHub] [iceberg] yyanyy commented on a change in pull request #1820: Core: update record_count behavior, include in manifest reader

[GitBox <gi...@apache.org>]

yyanyy commented on a change in pull request #1820:
URL: https://github.com/apache/iceberg/pull/1820#discussion_r538784120



##########
File path: core/src/main/java/org/apache/iceberg/ManifestReader.java
##########
@@ -52,8 +54,13 @@
 public class ManifestReader<F extends ContentFile<F>>
     extends CloseableGroup implements CloseableIterable<F> {
   static final ImmutableList<String> ALL_COLUMNS = ImmutableList.of("*");
-  static final Set<String> STATS_COLUMNS = Sets.newHashSet(
+
+  // the difference between the two stats set below is to support ContentFile.copyWithoutStats(), which
+  // still keeps record count.
+  private static final Set<String> STATS_COLUMNS = Sets.newHashSet(

Review comment:
       Sounds good, I'll add `record_count` to the set so that the set tracks all stats required for filtering data/delete file, and special-case `record_count` in `dropStats()` to account for the case that selecting only `record_count` will still result in `copyWithoutStats` instead of a full copy. (This is actually the same as the current logic, just consolidate the two sets into one)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org