You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry <am...@hortonworks.com> on 2019/03/29 18:02:36 UTC
Review Request 70343: AtlasGraphProvider Support for Graph with
Batch-loading Enabled
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70343/
-----------------------------------------------------------
Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3091
https://issues.apache.org/jira/browse/ATLAS-3091
Repository: atlas
Description
-------
**Approach**
Minor refactoring to get AtlasGraph with batch-loading enabled.
Diffs
-----
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GraphDatabase.java 3dfc6e8de
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java 93284140c
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 2f367d5e2
repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java 5aa8033cb
repository/src/main/java/org/apache/atlas/repository/graph/IAtlasGraphProvider.java a2cac2df5
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/BulkLoadingTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/70343/diff/1/
Testing
-------
**Unit tests**
Additional tests.
**Pre-commit build**
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1006/
Thanks,
Ashutosh Mestry
Re: Review Request 70343: AtlasGraphProvider Support for Graph with
Batch-loading Enabled
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70343/#review214444
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On March 29, 2019, 6:02 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70343/
> -----------------------------------------------------------
>
> (Updated March 29, 2019, 6:02 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3091
> https://issues.apache.org/jira/browse/ATLAS-3091
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
>
> Minor refactoring to get AtlasGraph with batch-loading enabled.
>
>
> Diffs
> -----
>
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GraphDatabase.java 3dfc6e8de
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java 93284140c
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 2f367d5e2
> repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java 5aa8033cb
> repository/src/main/java/org/apache/atlas/repository/graph/IAtlasGraphProvider.java a2cac2df5
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/BulkLoadingTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/70343/diff/1/
>
>
> Testing
> -------
>
> **Unit tests**
> Additional tests.
>
> **Pre-commit build**
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1006/
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 70343: AtlasGraphProvider Support for Graph with
Batch-loading Enabled
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70343/#review214443
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On March 29, 2019, 11:02 a.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70343/
> -----------------------------------------------------------
>
> (Updated March 29, 2019, 11:02 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3091
> https://issues.apache.org/jira/browse/ATLAS-3091
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
>
> Minor refactoring to get AtlasGraph with batch-loading enabled.
>
>
> Diffs
> -----
>
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GraphDatabase.java 3dfc6e8de
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java 93284140c
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 2f367d5e2
> repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java 5aa8033cb
> repository/src/main/java/org/apache/atlas/repository/graph/IAtlasGraphProvider.java a2cac2df5
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/BulkLoadingTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/70343/diff/1/
>
>
> Testing
> -------
>
> **Unit tests**
> Additional tests.
>
> **Pre-commit build**
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1006/
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 70343: AtlasGraphProvider Support for Graph with
Batch-loading Enabled
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70343/#review214449
-----------------------------------------------------------
Can you rebase the patch. It doesn't apply cleanly to 'master' branch.
- Sarath Subramanian
On March 29, 2019, 11:02 a.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70343/
> -----------------------------------------------------------
>
> (Updated March 29, 2019, 11:02 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3091
> https://issues.apache.org/jira/browse/ATLAS-3091
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
>
> Minor refactoring to get AtlasGraph with batch-loading enabled.
>
>
> Diffs
> -----
>
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GraphDatabase.java 3dfc6e8de
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java 93284140c
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 2f367d5e2
> repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java 5aa8033cb
> repository/src/main/java/org/apache/atlas/repository/graph/IAtlasGraphProvider.java a2cac2df5
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/BulkLoadingTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/70343/diff/1/
>
>
> Testing
> -------
>
> **Unit tests**
> Additional tests.
>
> **Pre-commit build**
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1006/
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 70343: AtlasGraphProvider Support for Graph with
Batch-loading Enabled
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70343/#review214452
-----------------------------------------------------------
patch still doesn't apply cleanly. Diff between 1-2 contains only whitespace changes - https://reviews.apache.org/r/70343/diff/1-2/
- Sarath Subramanian
On April 7, 2019, 11:40 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70343/
> -----------------------------------------------------------
>
> (Updated April 7, 2019, 11:40 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3091
> https://issues.apache.org/jira/browse/ATLAS-3091
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
>
> Minor refactoring to get AtlasGraph with batch-loading enabled.
>
>
> Diffs
> -----
>
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GraphDatabase.java 3dfc6e8de
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java 8eea96b68
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 2f367d5e2
> repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java 5aa8033cb
> repository/src/main/java/org/apache/atlas/repository/graph/IAtlasGraphProvider.java a2cac2df5
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/BulkLoadingTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/70343/diff/2/
>
>
> Testing
> -------
>
> **Unit tests**
> Additional tests.
>
> **Pre-commit build**
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1006/
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 70343: AtlasGraphProvider Support for Graph with
Batch-loading Enabled
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70343/
-----------------------------------------------------------
(Updated April 8, 2019, 6:40 a.m.)
Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Updates include: Patch rebased.
Bugs: ATLAS-3091
https://issues.apache.org/jira/browse/ATLAS-3091
Repository: atlas
Description
-------
**Approach**
Minor refactoring to get AtlasGraph with batch-loading enabled.
Diffs (updated)
-----
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GraphDatabase.java 3dfc6e8de
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java 8eea96b68
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java 2f367d5e2
repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java 5aa8033cb
repository/src/main/java/org/apache/atlas/repository/graph/IAtlasGraphProvider.java a2cac2df5
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/BulkLoadingTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/70343/diff/2/
Changes: https://reviews.apache.org/r/70343/diff/1-2/
Testing
-------
**Unit tests**
Additional tests.
**Pre-commit build**
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1006/
Thanks,
Ashutosh Mestry