You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/09 05:46:49 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3056: Add Decimal128 and Decimal256 to downcast_primitive

tustvold commented on code in PR #3056:
URL: https://github.com/apache/arrow-rs/pull/3056#discussion_r1017452653


##########
arrow/src/row/mod.rs:
##########
@@ -726,6 +697,21 @@ unsafe fn decode_column(
             )))
         }
     };
+    let array: ArrayRef = match &field.data_type {

Review Comment:
   I think we should probably be passing the data type into `decode_primitive` so that it can correctly construct the array with the correct data type. I suspect the current logic will lose the timestamp for timezones :thinking: 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org