[GitHub] [apisix] spacewander commented on issue #6007: Proposal: support Forward Auth authenticate plugin

[GitBox <gi...@apache.org>]

spacewander commented on issue #6007:
URL: https://github.com/apache/apisix/issues/6007#issuecomment-1005486942


   After reading https://doc.traefik.io/traefik/middlewares/http/forwardauth/, it seems the authResponseHeaders in that plugin is different from the one in the proposal.
   
   > The authResponseHeaders option is the list of headers to copy from the authentication server response and set on forwarded request, replacing any existing conflicting headers.
   
   Those headers are used to set on forwarded request.
   
   To make thing clear, maybe we can use `upstream_headers` and `client_headers`, like this one in Envoy:
   https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/http/ext_authz/v3/ext_authz.proto#extensions-filters-http-ext-authz-v3-authorizationresponse
   
   Another question, what if the request already has `X-Forwarded-XX` header?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org