You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/22 14:38:29 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #35612: [SPARK-38289][SQL] Refactor SQL CLI exit code to make it more clear
AngersZhuuuu opened a new pull request #35612:
URL: https://github.com/apache/spark/pull/35612
### What changes were proposed in this pull request?
In this pr we define exit code use in SQL CLI and refactor the code.
After this change can make the exit relate code more clear.
### Why are the changes needed?
Make code more clear
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Not need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #35612: [SPARK-38289][SQL] Refactor SQL CLI exit code to make it more clear
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #35612:
URL: https://github.com/apache/spark/pull/35612#discussion_r813493419
##########
File path: sql/hive-thriftserver/src/main/java/org/apache/hive/service/server/HiveServer2.java
##########
@@ -19,6 +19,7 @@
import java.util.Properties;
+import org.apache.spark.util.SparkExitCode;
Review comment:
> import order
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu edited a comment on pull request #35612: [SPARK-38289][SQL] Refactor SQL CLI exit code to make it more clear
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu edited a comment on pull request #35612:
URL: https://github.com/apache/spark/pull/35612#issuecomment-1048374830
gentle ping @yaooqinn @wangyum @cloud-fan @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] codecov-commenter removed a comment on pull request #35612: [SPARK-38289][SQL] Refactor SQL CLI exit code to make it more clear
Posted by GitBox <gi...@apache.org>.
codecov-commenter removed a comment on pull request #35612:
URL: https://github.com/apache/spark/pull/35612#issuecomment-1049748771
# [Codecov](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#35612](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c4b013f) into [master](https://codecov.io/gh/apache/spark/commit/ae67adde4d2dc0a75e03710fc3e66ea253feeda3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ae67add) will **decrease** coverage by `7.67%`.
> The diff coverage is `82.46%`.
> :exclamation: Current head c4b013f differs from pull request most recent head 80d8d3e. Consider uploading reports for the commit 80d8d3e to get more accurate results
[](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #35612 +/- ##
==========================================
- Coverage 91.22% 83.55% -7.68%
==========================================
Files 297 257 -40
Lines 64441 58837 -5604
Branches 9914 9305 -609
==========================================
- Hits 58789 49163 -9626
- Misses 4288 8469 +4181
+ Partials 1364 1205 -159
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `83.53% <82.46%> (-7.67%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [python/pyspark/context.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvY29udGV4dC5weQ==) | `61.34% <50.00%> (-25.64%)` | :arrow_down: |
| [python/pyspark/sql/dataframe.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2RhdGFmcmFtZS5weQ==) | `80.86% <75.00%> (+0.07%)` | :arrow_up: |
| [python/pyspark/mllib/tree.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvbWxsaWIvdHJlZS5weQ==) | `88.88% <82.35%> (-3.04%)` | :arrow_down: |
| [python/pyspark/mllib/feature.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvbWxsaWIvZmVhdHVyZS5weQ==) | `84.13% <83.18%> (-2.76%)` | :arrow_down: |
| [python/pyspark/pandas/generic.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvcGFuZGFzL2dlbmVyaWMucHk=) | `87.97% <100.00%> (ø)` | |
| [python/pyspark/join.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvam9pbi5weQ==) | `12.12% <0.00%> (-81.82%)` | :arrow_down: |
| [python/pyspark/ml/tuning.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvbWwvdHVuaW5nLnB5) | `25.03% <0.00%> (-67.46%)` | :arrow_down: |
| [python/pyspark/ml/pipeline.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvbWwvcGlwZWxpbmUucHk=) | `35.53% <0.00%> (-59.40%)` | :arrow_down: |
| [python/pyspark/util.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvdXRpbC5weQ==) | `30.76% <0.00%> (-54.71%)` | :arrow_down: |
| [python/pyspark/shuffle.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc2h1ZmZsZS5weQ==) | `18.73% <0.00%> (-53.68%)` | :arrow_down: |
| ... and [86 more](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b46b74c...80d8d3e](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] codecov-commenter commented on pull request #35612: [SPARK-38289][SQL] Refactor SQL CLI exit code to make it more clear
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #35612:
URL: https://github.com/apache/spark/pull/35612#issuecomment-1049748771
# [Codecov](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#35612](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c4b013f) into [master](https://codecov.io/gh/apache/spark/commit/ae67adde4d2dc0a75e03710fc3e66ea253feeda3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ae67add) will **decrease** coverage by `29.59%`.
> The diff coverage is `71.42%`.
> :exclamation: Current head c4b013f differs from pull request most recent head 80d8d3e. Consider uploading reports for the commit 80d8d3e to get more accurate results
[](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #35612 +/- ##
===========================================
- Coverage 91.22% 61.63% -29.60%
===========================================
Files 297 202 -95
Lines 64441 40267 -24174
Branches 9914 7524 -2390
===========================================
- Hits 58789 24820 -33969
- Misses 4288 14233 +9945
+ Partials 1364 1214 -150
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `61.63% <71.42%> (-29.57%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [python/pyspark/context.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvY29udGV4dC5weQ==) | `46.99% <50.00%> (-39.99%)` | :arrow_down: |
| [python/pyspark/sql/dataframe.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2RhdGFmcmFtZS5weQ==) | `49.45% <75.00%> (-31.34%)` | :arrow_down: |
| [python/pyspark/pandas/generic.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvcGFuZGFzL2dlbmVyaWMucHk=) | `37.02% <100.00%> (-50.96%)` | :arrow_down: |
| [python/pyspark/join.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvam9pbi5weQ==) | `12.12% <0.00%> (-81.82%)` | :arrow_down: |
| [python/pyspark/sql/observation.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL29ic2VydmF0aW9uLnB5) | `26.08% <0.00%> (-69.57%)` | :arrow_down: |
| [python/pyspark/ml/tuning.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvbWwvdHVuaW5nLnB5) | `25.03% <0.00%> (-67.46%)` | :arrow_down: |
| [python/pyspark/pandas/frame.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvcGFuZGFzL2ZyYW1lLnB5) | `33.03% <0.00%> (-64.03%)` | :arrow_down: |
| [python/pyspark/streaming/dstream.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3RyZWFtaW5nL2RzdHJlYW0ucHk=) | `22.65% <0.00%> (-61.72%)` | :arrow_down: |
| [python/pyspark/util.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvdXRpbC5weQ==) | `24.78% <0.00%> (-60.69%)` | :arrow_down: |
| [python/pyspark/streaming/util.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3RyZWFtaW5nL3V0aWwucHk=) | `29.62% <0.00%> (-60.50%)` | :arrow_down: |
| ... and [194 more](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b46b74c...80d8d3e](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35612: [SPARK-38289][SQL] Refactor SQL CLI exit code to make it more clear
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35612:
URL: https://github.com/apache/spark/pull/35612#issuecomment-1049610447
> So many, and all of these exit code is -1, 1, 0, I think it's easy to understand. Not so necessary
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #35612: [SPARK-38289][SQL] Refactor SQL CLI exit code to make it more clear
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #35612:
URL: https://github.com/apache/spark/pull/35612#issuecomment-1049599988
> I found that there are many similar cases in Spark code, for example:
>
> https://github.com/apache/spark/blob/c4b013f4129969668323d20e40869411b35ed5e7/core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala#L269-L277
>
> https://github.com/apache/spark/blob/c4b013f4129969668323d20e40869411b35ed5e7/core/src/main/scala/org/apache/spark/api/r/RBackend.scala#L111-L118
>
> and so on. Shall we fix them all in one?
So many, and all of these exit code is `-1`, `1`, `0`, I think it's easy to understand. Not so necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #35612: [SPARK-38289][SQL] Refactor SQL CLI exit code to make it more clear
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #35612:
URL: https://github.com/apache/spark/pull/35612#issuecomment-1050447496
gentle ping @HyukjinKwon @cloud-fan @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] codecov-commenter edited a comment on pull request #35612: [SPARK-38289][SQL] Refactor SQL CLI exit code to make it more clear
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #35612:
URL: https://github.com/apache/spark/pull/35612#issuecomment-1049748771
# [Codecov](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#35612](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c4b013f) into [master](https://codecov.io/gh/apache/spark/commit/ae67adde4d2dc0a75e03710fc3e66ea253feeda3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ae67add) will **decrease** coverage by `7.67%`.
> The diff coverage is `82.46%`.
> :exclamation: Current head c4b013f differs from pull request most recent head 80d8d3e. Consider uploading reports for the commit 80d8d3e to get more accurate results
[](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #35612 +/- ##
==========================================
- Coverage 91.22% 83.55% -7.68%
==========================================
Files 297 257 -40
Lines 64441 58837 -5604
Branches 9914 9305 -609
==========================================
- Hits 58789 49163 -9626
- Misses 4288 8469 +4181
+ Partials 1364 1205 -159
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `83.53% <82.46%> (-7.67%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [python/pyspark/context.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvY29udGV4dC5weQ==) | `61.34% <50.00%> (-25.64%)` | :arrow_down: |
| [python/pyspark/sql/dataframe.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2RhdGFmcmFtZS5weQ==) | `80.86% <75.00%> (+0.07%)` | :arrow_up: |
| [python/pyspark/mllib/tree.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvbWxsaWIvdHJlZS5weQ==) | `88.88% <82.35%> (-3.04%)` | :arrow_down: |
| [python/pyspark/mllib/feature.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvbWxsaWIvZmVhdHVyZS5weQ==) | `84.13% <83.18%> (-2.76%)` | :arrow_down: |
| [python/pyspark/pandas/generic.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvcGFuZGFzL2dlbmVyaWMucHk=) | `87.97% <100.00%> (ø)` | |
| [python/pyspark/join.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvam9pbi5weQ==) | `12.12% <0.00%> (-81.82%)` | :arrow_down: |
| [python/pyspark/ml/tuning.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvbWwvdHVuaW5nLnB5) | `25.03% <0.00%> (-67.46%)` | :arrow_down: |
| [python/pyspark/ml/pipeline.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvbWwvcGlwZWxpbmUucHk=) | `35.53% <0.00%> (-59.40%)` | :arrow_down: |
| [python/pyspark/util.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvdXRpbC5weQ==) | `30.76% <0.00%> (-54.71%)` | :arrow_down: |
| [python/pyspark/shuffle.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc2h1ZmZsZS5weQ==) | `18.73% <0.00%> (-53.68%)` | :arrow_down: |
| ... and [86 more](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b46b74c...80d8d3e](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] codecov-commenter edited a comment on pull request #35612: [SPARK-38289][SQL] Refactor SQL CLI exit code to make it more clear
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #35612:
URL: https://github.com/apache/spark/pull/35612#issuecomment-1049748771
# [Codecov](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#35612](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c4b013f) into [master](https://codecov.io/gh/apache/spark/commit/ae67adde4d2dc0a75e03710fc3e66ea253feeda3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ae67add) will **decrease** coverage by `15.83%`.
> The diff coverage is `71.42%`.
> :exclamation: Current head c4b013f differs from pull request most recent head 80d8d3e. Consider uploading reports for the commit 80d8d3e to get more accurate results
[](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #35612 +/- ##
===========================================
- Coverage 91.22% 75.39% -15.84%
===========================================
Files 297 211 -86
Lines 64441 49886 -14555
Branches 9914 8313 -1601
===========================================
- Hits 58789 37611 -21178
- Misses 4288 11267 +6979
+ Partials 1364 1008 -356
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `75.37% <71.42%> (-15.83%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [python/pyspark/context.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvY29udGV4dC5weQ==) | `47.68% <50.00%> (-39.30%)` | :arrow_down: |
| [python/pyspark/sql/dataframe.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL2RhdGFmcmFtZS5weQ==) | `53.42% <75.00%> (-27.37%)` | :arrow_down: |
| [python/pyspark/pandas/generic.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvcGFuZGFzL2dlbmVyaWMucHk=) | `87.97% <100.00%> (ø)` | |
| [python/pyspark/join.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvam9pbi5weQ==) | `12.12% <0.00%> (-81.82%)` | :arrow_down: |
| [python/pyspark/sql/observation.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3FsL29ic2VydmF0aW9uLnB5) | `26.08% <0.00%> (-69.57%)` | :arrow_down: |
| [python/pyspark/ml/tuning.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvbWwvdHVuaW5nLnB5) | `25.03% <0.00%> (-67.46%)` | :arrow_down: |
| [python/pyspark/streaming/dstream.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3RyZWFtaW5nL2RzdHJlYW0ucHk=) | `22.65% <0.00%> (-61.72%)` | :arrow_down: |
| [python/pyspark/util.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvdXRpbC5weQ==) | `24.78% <0.00%> (-60.69%)` | :arrow_down: |
| [python/pyspark/streaming/util.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3Bhcmsvc3RyZWFtaW5nL3V0aWwucHk=) | `29.62% <0.00%> (-60.50%)` | :arrow_down: |
| [python/pyspark/resource/requests.py](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3B5c3BhcmsvcmVzb3VyY2UvcmVxdWVzdHMucHk=) | `35.25% <0.00%> (-60.44%)` | :arrow_down: |
| ... and [161 more](https://codecov.io/gh/apache/spark/pull/35612/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b46b74c...80d8d3e](https://codecov.io/gh/apache/spark/pull/35612?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #35612: [SPARK-38289][SQL] Refactor SQL CLI exit code to make it more clear
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #35612:
URL: https://github.com/apache/spark/pull/35612#discussion_r812839422
##########
File path: sql/hive-thriftserver/src/main/java/org/apache/hive/service/server/HiveServer2.java
##########
@@ -19,6 +19,7 @@
import java.util.Properties;
+import org.apache.spark.util.SparkExitCode;
Review comment:
import order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #35612: [SPARK-38289][SQL] Refactor SQL CLI exit code to make it more clear
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #35612:
URL: https://github.com/apache/spark/pull/35612#issuecomment-1048374830
gentle ping @yaooqinn @wangyum @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35612: [SPARK-38289][SQL] Refactor SQL CLI exit code to make it more clear
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35612:
URL: https://github.com/apache/spark/pull/35612#issuecomment-1049596903
I found that there are many similar cases in Spark code, for example:
https://github.com/apache/spark/blob/c4b013f4129969668323d20e40869411b35ed5e7/core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala#L269-L277
https://github.com/apache/spark/blob/c4b013f4129969668323d20e40869411b35ed5e7/core/src/main/scala/org/apache/spark/api/r/RBackend.scala#L111-L118
and so on. Shall we fix them all in one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35612: [SPARK-38289][SQL] Refactor SQL CLI exit code to make it more clear
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35612:
URL: https://github.com/apache/spark/pull/35612#issuecomment-1050462111
> So many, and all of these exit code is -1, 1, 0, I think it's easy to understand. Not so necessary
I thought again, if -1, 0 and 1 are easy to understand, I think we don't need to name them, just name the states that are not easy to understand is enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org