You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/01 21:06:06 UTC
[GitHub] [kafka] mjsax commented on a change in pull request #8600: KAFKA-9928: Fix flaky GlobalKTableEOSIntegrationTest
mjsax commented on a change in pull request #8600:
URL: https://github.com/apache/kafka/pull/8600#discussion_r418737835
##########
File path: streams/src/test/java/org/apache/kafka/streams/integration/GlobalKTableEOSIntegrationTest.java
##########
@@ -304,59 +382,64 @@ private void startStreams() {
private void produceTopicValues(final String topic) {
IntegrationTestUtils.produceKeyValuesSynchronously(
- topic,
- Arrays.asList(
- new KeyValue<>("a", 1L),
- new KeyValue<>("b", 2L),
- new KeyValue<>("c", 3L),
- new KeyValue<>("d", 4L),
- new KeyValue<>("e", 5L)),
- TestUtils.producerConfig(
- CLUSTER.bootstrapServers(),
- StringSerializer.class,
- LongSerializer.class,
- new Properties()),
- mockTime);
+ topic,
+ Arrays.asList(
+ new KeyValue<>("a", 1L),
+ new KeyValue<>("b", 2L),
+ new KeyValue<>("c", 3L),
+ new KeyValue<>("d", 4L),
+ new KeyValue<>("e", 5L)
+ ),
+ TestUtils.producerConfig(
+ CLUSTER.bootstrapServers(),
+ StringSerializer.class,
+ LongSerializer.class,
+ new Properties()
+ ),
+ mockTime
+ );
}
private void produceAbortedMessages() throws Exception {
final Properties properties = new Properties();
properties.put(ProducerConfig.TRANSACTIONAL_ID_CONFIG, "someid");
- properties.put(ProducerConfig.RETRIES_CONFIG, 1);
Review comment:
This might be the actually fix. Not sure why we set retries to one, but if we would loose input data, we would never complete the result and the test would time out. (Maybe not relevant for aborted message, but same below)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org