You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2016/12/30 07:11:01 UTC

[GitHub] zeppelin pull request #1825: [DOCS][ZEPPELIN-1586] Add 'Security' section un...

GitHub user AhyoungRyu opened a pull request:

    https://github.com/apache/zeppelin/pull/1825

    [DOCS][ZEPPELIN-1586] Add 'Security' section under notebook restapi docs

    ### What is this PR for?
    After #1567 merged we can get/set note permission information for a certain note. But this info is not described in anywhere. So I added "Security" section under [docs/rest-api/rest-notebook.md](https://github.com/apache/zeppelin/blob/master/docs/rest-api/rest-notebook.md). 
    
    And currently so many operations are placed under one section like below.
    <img src="https://cloud.githubusercontent.com/assets/10060731/21560964/c55d41cc-cea9-11e6-96ac-68f762c68bff.png" width="400px">
    
    So I split them under each `Note opersions`, `Paragraph operations`, `Cron jobs`, and `Security`.
    <img src="https://cloud.githubusercontent.com/assets/10060731/21560971/cd57cf46-cea9-11e6-9a41-95c817594c9c.png" width="400px">
    
    
    ### What type of PR is it?
    Documentation
    
    ### What is the Jira issue?
    [ZEPPELIN-1877](https://issues.apache.org/jira/browse/ZEPPELIN-1877)
    
    ### How should this be tested?
    Please see the below screenshots :)
    
    ### Screenshots (if appropriate)
    ![screen shot 2016-12-30 at 3 58 39 pm](https://cloud.githubusercontent.com/assets/10060731/21561001/1b83f2b2-ceaa-11e6-813d-6885c8dad3fc.png)
    ![screen shot 2016-12-30 at 3 58 46 pm](https://cloud.githubusercontent.com/assets/10060731/21561004/1d6695da-ceaa-11e6-8460-7a95377ede3b.png)
    ![screen shot 2016-12-30 at 3 58 50 pm](https://cloud.githubusercontent.com/assets/10060731/21561006/2001ee5c-ceaa-11e6-90a1-7619d1b29bee.png)
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-1586/docs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1825.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1825
    
----
commit 09d22d30ff8f927a5754c9c6f0f74ffb28ef8a71
Author: AhyoungRyu <fb...@hanmail.net>
Date:   2016-12-30T06:59:20Z

    Add 'Security' section under notebook restapi docs

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1825: [DOCS][ZEPPELIN-1586] Add 'Security' section under not...

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1825
  
    I updated this docs page again since REST API operations need to be listed as CRUD order. And removed unimplemented response code info as well. Please see the updated screenshot images :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1825: [DOCS][ZEPPELIN-1586] Add 'Security' section un...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1825


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1825: [DOCS][ZEPPELIN-1586] Add 'Security' section under not...

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1825
  
    Thanks @minahlee!
    Will merge if there are no more comments on this. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1825: [DOCS][ZEPPELIN-1586] Add 'Security' section under not...

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1825
  
    @anthonycorbacho As a creator of this operations, could you please help review this PR? :D


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1825: [DOCS][ZEPPELIN-1586] Add 'Security' section under not...

Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:

    https://github.com/apache/zeppelin/pull/1825
  
    Nice improvement, LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---