You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by an...@apache.org on 2006/03/10 07:41:59 UTC
svn commit: r384717 - in /cocoon/branches/BRANCH_2_1_X:
src/java/org/apache/cocoon/components/pipeline/impl/AbstractCachingProcessingPipeline.java
status.xml
Author: antonio
Date: Thu Mar 9 22:41:58 2006
New Revision: 384717
URL: http://svn.apache.org/viewcvs?rev=384717&view=rev
Log:
<action dev="AG" type="fix" fixes-bug="COCOON-1799" due-to="Simone Gianni" due-to-email="s.gianni@thebug.it">
Threads waste when reading a not found resource.
</action>
Modified:
cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/components/pipeline/impl/AbstractCachingProcessingPipeline.java
cocoon/branches/BRANCH_2_1_X/status.xml
Modified: cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/components/pipeline/impl/AbstractCachingProcessingPipeline.java
URL: http://svn.apache.org/viewcvs/cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/components/pipeline/impl/AbstractCachingProcessingPipeline.java?rev=384717&r1=384716&r2=384717&view=diff
==============================================================================
--- cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/components/pipeline/impl/AbstractCachingProcessingPipeline.java (original)
+++ cocoon/branches/BRANCH_2_1_X/src/java/org/apache/cocoon/components/pipeline/impl/AbstractCachingProcessingPipeline.java Thu Mar 9 22:41:58 2006
@@ -882,8 +882,6 @@
if (readerValidity != null) {
outputStream = environment.getOutputStream(this.outputBufferSize);
outputStream = new CachingOutputStream(outputStream);
- } else {
- pcKey = null;
}
}
@@ -906,7 +904,7 @@
}
// store the response
- if (pcKey != null) {
+ if (pcKey != null && readerValidity != null) {
final CachedResponse res = new CachedResponse(new SourceValidity[] {readerValidity},
((CachingOutputStream)outputStream).getContent());
res.setContentType(environment.getContentType());
Modified: cocoon/branches/BRANCH_2_1_X/status.xml
URL: http://svn.apache.org/viewcvs/cocoon/branches/BRANCH_2_1_X/status.xml?rev=384717&r1=384716&r2=384717&view=diff
==============================================================================
--- cocoon/branches/BRANCH_2_1_X/status.xml (original)
+++ cocoon/branches/BRANCH_2_1_X/status.xml Thu Mar 9 22:41:58 2006
@@ -180,6 +180,9 @@
<release version="@version@" date="@date@">
-->
<release version="2.1.9" date="TBD">
+ <action dev="AG" type="fix" fixes-bug="COCOON-1799" due-to="Simone Gianni" due-to-email="s.gianni@thebug.it">
+ Threads waste when reading a not found resource.
+ </action>
<action dev="AG" type="fix" fixes-bug="COCOON-1796" due-to="Freek Segers" due-to-email="freek.segers@nerocmediaware.nl">
TraversableGenerator calls resolveURI() twice but release() only once.
</action>
Re: svn commit: r384717 - in /cocoon/branches/BRANCH_2_1_X: src/java/org/apache/cocoon/components/pipeline/impl/AbstractCachingProcessingPipeline.java
status.xml
Posted by Antonio Gallardo <ag...@agssa.net>.
Jean-Baptiste Quenot wrote:
>* antonio@apache.org:
>
>
>>Author: antonio
>>Date: Thu Mar 9 22:41:58 2006
>>New Revision: 384717
>>
>>URL: http://svn.apache.org/viewcvs?rev=384717&view=rev
>>Log:
>>
>><action dev="AG" type="fix" fixes-bug="COCOON-1799" due-to="Simone Gianni" due-to-email="s.gianni@thebug.it">
>> Threads waste when reading a not found resource.
>></action>
>>
>>
>
>Actually the locking feature does not appear in status.xml. So
>IMHO this bugfix should not be mentioned in status.xml. What
>needs to be mentioned is the new locking feature.
>
>
IMHO, the reason why it should not appear in the status.xml is because
the bug was never released. I will delete it now.
>This feature must also be ported to trunk.
>
>
+1 I will prefer if Max can do that.
Best Regards,
Antonio Gallardo
Re: svn commit: r384717 - in /cocoon/branches/BRANCH_2_1_X: src/java/org/apache/cocoon/components/pipeline/impl/AbstractCachingProcessingPipeline.java status.xml
Posted by Jean-Baptiste Quenot <jb...@apache.org>.
* antonio@apache.org:
> Author: antonio
> Date: Thu Mar 9 22:41:58 2006
> New Revision: 384717
>
> URL: http://svn.apache.org/viewcvs?rev=384717&view=rev
> Log:
>
> <action dev="AG" type="fix" fixes-bug="COCOON-1799" due-to="Simone Gianni" due-to-email="s.gianni@thebug.it">
> Threads waste when reading a not found resource.
> </action>
Actually the locking feature does not appear in status.xml. So
IMHO this bugfix should not be mentioned in status.xml. What
needs to be mentioned is the new locking feature.
This feature must also be ported to trunk.
--
Jean-Baptiste Quenot
http://caraldi.com/jbq/