You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Jason Grant (JIRA)" <ji...@codehaus.org> on 2005/08/11 13:40:57 UTC
[jira] Commented: (MNG-723) [patch] assembly:unpack
[ http://jira.codehaus.org/browse/MNG-723?page=comments#action_44305 ]
Jason Grant commented on MNG-723:
---------------------------------
I want to do a further update - AssemblyMojo has been wired so far to assume that dependencies are jars - if unpack is required, then it tries to unjar the dependency. I'd like to contribute an additional enhancement to allow it to handle zips too.
Also, reading my code just now, I think more methods should be pulled down from the abstract class. I won't burden you with more diffs just now, but I might ask if it is OK to check this stuff in rather than polluting jira issues with superceded versions (I cannot delete my attachments above).
> [patch] assembly:unpack
> -----------------------
>
> Key: MNG-723
> URL: http://jira.codehaus.org/browse/MNG-723
> Project: Maven 2
> Type: New Feature
> Components: maven-plugins
> Versions: 2.0-beta-1
> Reporter: Jason Grant
> Assignee: John Casey
> Priority: Minor
> Fix For: 2.0-beta-1
> Attachments: AbstractAssemblyMojo.java, AssemblyMojo.diff, UnpackMojo.java, UnpackMojo.java
>
>
> I've coded an assembly:unpack goal. It will unpack any dependencies in the project whose filenames indicate type jar or zip. These are unpacked into the workDirectory.
> I went about it by pulling common infrastructure out of AssemblyMojo and placing it in a new abstract superclass AbstractAssemblyMojo. Another new class, called UnpackMojo now also resides in maven-assembly-plugin.
> I was going to code an integration test for this, however I will instead do some work on http://jira.codehaus.org/browse/MNG-483 first, so that I can use the latter as the first step in the test. I'll write some supporting notes over on that jira issue.
> Note that this is the first code that I've contributed to Maven - I'm happy to take direction should I be breaking conventions. You'll see me from time to time on #maven as jasong.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org