You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Dave Brondsema <da...@brondsema.net> on 2015/08/10 17:53:41 UTC
[allura:tickets] #5940 Add forge name & logo options to default theme
---
** [tickets:#5940] Add forge name & logo options to default theme**
**Status:** open
**Milestone:** unreleased
**Labels:** sf-current sf-4
**Created:** Fri Mar 08, 2013 04:38 PM UTC by Dave Brondsema
**Last Updated:** Mon Jan 19, 2015 01:54 PM UTC
**Owner:** nobody
It'd be very nice to be able to configure the forge name and logo to be used on the header of all pages. This should be an option for forge deployers, without having to customize the theme.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #5940 Add forge name & logo options to default theme
Posted by Igor Bondarenko <je...@gmail.com>.
Setting height makes sense for me and logo notation would be great in this case for sure! Will do
---
** [tickets:#5940] Add forge name & logo options to default theme**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** sf-current sf-4
**Created:** Fri Mar 08, 2013 04:38 PM UTC by Dave Brondsema
**Last Updated:** Wed Dec 09, 2015 09:08 PM UTC
**Owner:** Igor Bondarenko
It'd be very nice to be able to configure the forge name and logo to be used on the header of all pages. This should be an option for forge deployers, without having to customize the theme.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #5940 Add forge name & logo options to default theme
Posted by Heith Seewald <hs...@slashdotmedia.com>.
- **status**: review --> in-progress
- **Comment**:
This is great -- I'm excited about this feature :)
This is looking great overall -- I just have a couple of notes:
1: We should add in some warnings instead of failing silently. Maybe something like:
~~~~
::python
if not os.path.isfile(image_full_path):
log.warning('Could not find logo at: %s' % image_full_path)
return False
if not image_path:
log.warning('Image path not set for nav_logo')
return False
~~~~
2: What do you think about making the image height settable or maybe just mentioning the ideal image dimensions in the comments?
3: For simple data structures like the one for “logo”, using a simple dot notation can be more readable:
~~~~
logo.link = /
logo.path = logo.png
~~~~
4: Because this is a universally useful feature -- it may be nice to mention it in our docs.
---
** [tickets:#5940] Add forge name & logo options to default theme**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** sf-current sf-4
**Created:** Fri Mar 08, 2013 04:38 PM UTC by Dave Brondsema
**Last Updated:** Wed Dec 09, 2015 05:56 PM UTC
**Owner:** Igor Bondarenko
It'd be very nice to be able to configure the forge name and logo to be used on the header of all pages. This should be an option for forge deployers, without having to customize the theme.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #5940 Add forge name & logo options to default theme
Posted by Igor Bondarenko <je...@gmail.com>.
- **status**: open --> in-progress
- **assigned_to**: Igor Bondarenko
---
** [tickets:#5940] Add forge name & logo options to default theme**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** sf-current sf-4
**Created:** Fri Mar 08, 2013 04:38 PM UTC by Dave Brondsema
**Last Updated:** Mon Aug 10, 2015 03:53 PM UTC
**Owner:** Igor Bondarenko
It'd be very nice to be able to configure the forge name and logo to be used on the header of all pages. This should be an option for forge deployers, without having to customize the theme.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #5940 Add forge name & logo options to default theme
Posted by Igor Bondarenko <je...@gmail.com>.
- **status**: in-progress --> review
- **Comment**:
Closed #880.
ib/5940**a** (rebased on master)
Note one test is failing here, but it is also failing on master. I've made fix for that https://forge-allura.apache.org/p/allura/git/merge-requests/63/
---
** [tickets:#5940] Add forge name & logo options to default theme**
**Status:** review
**Milestone:** unreleased
**Labels:** sf-current sf-4
**Created:** Fri Mar 08, 2013 04:38 PM UTC by Dave Brondsema
**Last Updated:** Thu Dec 10, 2015 11:00 AM UTC
**Owner:** Igor Bondarenko
It'd be very nice to be able to configure the forge name and logo to be used on the header of all pages. This should be an option for forge deployers, without having to customize the theme.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #5940 Add forge name & logo options to default theme
Posted by Heith Seewald <hs...@slashdotmedia.com>.
- **status**: closed --> in-progress
---
** [tickets:#5940] Add forge name & logo options to default theme**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** sf-current sf-4
**Created:** Fri Mar 08, 2013 04:38 PM UTC by Dave Brondsema
**Last Updated:** Tue Dec 15, 2015 07:22 PM UTC
**Owner:** Igor Bondarenko
It'd be very nice to be able to configure the forge name and logo to be used on the header of all pages. This should be an option for forge deployers, without having to customize the theme.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #5940 Add forge name & logo options to default theme
Posted by Heith Seewald <hs...@slashdotmedia.com>.
- **Reviewer**: Heith Seewald
---
** [tickets:#5940] Add forge name & logo options to default theme**
**Status:** review
**Milestone:** unreleased
**Labels:** sf-current sf-4
**Created:** Fri Mar 08, 2013 04:38 PM UTC by Dave Brondsema
**Last Updated:** Mon Dec 07, 2015 08:23 AM UTC
**Owner:** Igor Bondarenko
It'd be very nice to be able to configure the forge name and logo to be used on the header of all pages. This should be an option for forge deployers, without having to customize the theme.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #5940 Add forge name & logo options to default theme
Posted by Dave Brondsema <da...@brondsema.net>.
- **labels**: sf-current, sf-4 --> sf-4
---
** [tickets:#5940] Add forge name & logo options to default theme**
**Status:** closed
**Milestone:** unreleased
**Labels:** sf-4
**Created:** Fri Mar 08, 2013 04:38 PM UTC by Dave Brondsema
**Last Updated:** Tue Dec 22, 2015 03:46 PM UTC
**Owner:** Igor Bondarenko
It'd be very nice to be able to configure the forge name and logo to be used on the header of all pages. This should be an option for forge deployers, without having to customize the theme.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #5940 Add forge name & logo options to default theme
Posted by Igor Bondarenko <je...@gmail.com>.
- **status**: in-progress --> review
- **Comment**:
Fixed and created a merge request https://forge-allura.apache.org/p/allura/git/merge-requests/67/
---
** [tickets:#5940] Add forge name & logo options to default theme**
**Status:** review
**Milestone:** unreleased
**Labels:** sf-current sf-4
**Created:** Fri Mar 08, 2013 04:38 PM UTC by Dave Brondsema
**Last Updated:** Wed Dec 16, 2015 07:00 PM UTC
**Owner:** Igor Bondarenko
It'd be very nice to be able to configure the forge name and logo to be used on the header of all pages. This should be an option for forge deployers, without having to customize the theme.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #5940 Add forge name & logo options to default theme
Posted by Igor Bondarenko <je...@gmail.com>.
- **status**: in-progress --> review
- **Comment**:
Closed #866. `ib/5940`
---
** [tickets:#5940] Add forge name & logo options to default theme**
**Status:** review
**Milestone:** unreleased
**Labels:** sf-current sf-4
**Created:** Fri Mar 08, 2013 04:38 PM UTC by Dave Brondsema
**Last Updated:** Fri Nov 27, 2015 08:13 AM UTC
**Owner:** Igor Bondarenko
It'd be very nice to be able to configure the forge name and logo to be used on the header of all pages. This should be an option for forge deployers, without having to customize the theme.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #5940 Add forge name & logo options to default theme
Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: review --> closed
---
** [tickets:#5940] Add forge name & logo options to default theme**
**Status:** closed
**Milestone:** unreleased
**Labels:** sf-current sf-4
**Created:** Fri Mar 08, 2013 04:38 PM UTC by Dave Brondsema
**Last Updated:** Mon Dec 21, 2015 01:17 PM UTC
**Owner:** Igor Bondarenko
It'd be very nice to be able to configure the forge name and logo to be used on the header of all pages. This should be an option for forge deployers, without having to customize the theme.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] Re: #5940 Add forge name & logo options to default theme
Posted by Heith Seewald <hs...@slashdotmedia.com>.
Nice catch!
I'll change the status back to in-progress.
---
** [tickets:#5940] Add forge name & logo options to default theme**
**Status:** closed
**Milestone:** unreleased
**Labels:** sf-current sf-4
**Created:** Fri Mar 08, 2013 04:38 PM UTC by Dave Brondsema
**Last Updated:** Tue Dec 15, 2015 07:22 PM UTC
**Owner:** Igor Bondarenko
It'd be very nice to be able to configure the forge name and logo to be used on the header of all pages. This should be an option for forge deployers, without having to customize the theme.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #5940 Add forge name & logo options to default theme
Posted by Dave Brondsema <da...@brondsema.net>.
I've noticed a few followup issues with this, would you mind fixing?
* the [rat test](https://builds.apache.org/job/Allura-rat/14/console) has failed becaue there is a new file without a license header
* the links in the footer have unnecessary left margin space.
---
** [tickets:#5940] Add forge name & logo options to default theme**
**Status:** closed
**Milestone:** unreleased
**Labels:** sf-current sf-4
**Created:** Fri Mar 08, 2013 04:38 PM UTC by Dave Brondsema
**Last Updated:** Tue Dec 15, 2015 05:39 PM UTC
**Owner:** Igor Bondarenko
It'd be very nice to be able to configure the forge name and logo to be used on the header of all pages. This should be an option for forge deployers, without having to customize the theme.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #5940 Add forge name & logo options to default theme
Posted by Heith Seewald <hs...@slashdotmedia.com>.
- **status**: review --> closed
- **Comment**:
This looks great, Igor -- nice work!
merged
---
** [tickets:#5940] Add forge name & logo options to default theme**
**Status:** closed
**Milestone:** unreleased
**Labels:** sf-current sf-4
**Created:** Fri Mar 08, 2013 04:38 PM UTC by Dave Brondsema
**Last Updated:** Tue Dec 15, 2015 12:33 PM UTC
**Owner:** Igor Bondarenko
It'd be very nice to be able to configure the forge name and logo to be used on the header of all pages. This should be an option for forge deployers, without having to customize the theme.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] Ticket 5940 discussion
Posted by Dave Brondsema <da...@brondsema.net>.
- **labels**: --> sf-current, sf-4
---
** [tickets:#5940] Add forge name & logo options to default theme**
**Status:** open
**Milestone:** unreleased
**Labels:** sf-current sf-4
**Created:** Fri Mar 08, 2013 04:38 PM UTC by Dave Brondsema
**Last Updated:** Mon Jan 19, 2015 01:54 PM UTC
**Owner:** nobody
It'd be very nice to be able to configure the forge name and logo to be used on the header of all pages. This should be an option for forge deployers, without having to customize the theme.
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.