[buildstream] branch tristan/fix-sources-generator created (now 89c27fd)

[gi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a change to branch tristan/fix-sources-generator
in repository https://gitbox.apache.org/repos/asf/buildstream.git.


      at 89c27fd  element.py: Fix sources() generator to be a generator.

This branch includes the following new commits:

     new 89c27fd  element.py: Fix sources() generator to be a generator.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

[buildstream] 01/01: element.py: Fix sources() generator to be a generator.

[gi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a commit to branch tristan/fix-sources-generator
in repository https://gitbox.apache.org/repos/asf/buildstream.git

commit 89c27fd1cc6f9efb6491419d0dfe98ae10d8ec0e
Author: Tristan van Berkom <tr...@codethink.co.uk>
AuthorDate: Mon Aug 24 16:53:27 2020 +0900

    element.py: Fix sources() generator to be a generator.
    
    Instead of a function which returns a generator, yield directly
    from the ElementSources delegated generator.
---
 src/buildstream/element.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/buildstream/element.py b/src/buildstream/element.py
index 4a29fd8..a748cba 100644
--- a/src/buildstream/element.py
+++ b/src/buildstream/element.py
@@ -415,7 +415,7 @@ class Element(Plugin):
         Yields:
            The sources of this element
         """
-        return self.__sources.sources()
+        yield from self.__sources.sources()
 
     def dependencies(self, scope: Scope, *, recurse: bool = True, visited=None) -> Iterator["Element"]:
         """dependencies(scope, *, recurse=True)