[GitHub] [arrow] mapleFU commented on issue #35746: [Parquet] Bump the format version from 2.4 -> 2.6

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on issue #35746:
URL: https://github.com/apache/arrow/issues/35746#issuecomment-1562207107

   I found that our implemention already supports `Timestamp`:
   
   ```c++
   /// \brief Allowed for physical type INT64.
   class PARQUET_EXPORT TimestampLogicalType : public LogicalType {
    public:
     static std::shared_ptr<const LogicalType> Make(bool is_adjusted_to_utc,
                                                    LogicalType::TimeUnit::unit time_unit,
                                                    bool is_from_converted_type = false,
                                                    bool force_set_converted_type = false);
     bool is_adjusted_to_utc() const;
     LogicalType::TimeUnit::unit time_unit() const;
   
     /// \brief If true, will not set LogicalType in Thrift metadata
     bool is_from_converted_type() const;
   
     /// \brief If true, will set ConvertedType for micros and millis
     /// resolution in legacy ConvertedType Thrift metadata
     bool force_set_converted_type() const;
   
    private:
     TimestampLogicalType() = default;
   };
   ```
   
   And timeunit has `NANO`
   
   ```
     struct TimeUnit {
       enum unit { UNKNOWN = 0, MILLIS = 1, MICROS, NANOS };
     };
   ```
   
   Do we already supports them?
   
   /cc @wgtmac 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org