[jira] [Updated] (TOMEE-1417) [TEST] Incorrect test function PropertiesTest assertTest

["Romain Manni-Bucau (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TOMEE-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Romain Manni-Bucau updated TOMEE-1417:
--------------------------------------
    Fix Version/s:     (was: 7.0.3)
                   7.0.4

> [TEST] Incorrect test function PropertiesTest assertTest
> --------------------------------------------------------
>
>                 Key: TOMEE-1417
>                 URL: https://issues.apache.org/jira/browse/TOMEE-1417
>             Project: TomEE
>          Issue Type: Improvement
>    Affects Versions: 7.0.0
>            Reporter: Daniel Kasmeroglu
>            Priority: Trivial
>             Fix For: 7.0.4
>
>
> The helper function _PropertiesTest$assertProperties_ contains an invalid comparison for a different property:
> {code:java}
> if (expectedValue != expectedValue && (expectedValue == null || !expectedValue.equals(actual))) {
>   ...
> }
> {code}
> The comparison *expectedValue != expectedValue* obviously always returns false so the contained code will never be executed.
> Furthermore the only use cases of this function returns at it's entry due to the fact that the supplied parameters are always equal.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)