You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Pedro Santos (JIRA)" <ji...@apache.org> on 2011/02/08 00:56:57 UTC

[jira] Issue Comment Edited: (WICKET-3415) 1.5 equivalant of protected void WebRequestCycle.onRequestTargetSet(IRequestTarget requestTarget) is mising from AbstractRequestCycleListener

    [ https://issues.apache.org/jira/browse/WICKET-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991495#comment-12991495 ] 

Pedro Santos edited comment on WICKET-3415 at 2/7/11 11:55 PM:
---------------------------------------------------------------

Request cycle on 1.5 maintain an stack of executions of request handlers, that is managed by RequestHandlerStack.
the patch:
- add those callback to IRequestCycleListener:
onRequestHandlerResolved
onExceptionRequestHandlerResolved
onRequestHandlerScheduled
- removes RequestHandlerStack from the RequestCycle hierarchy, since is it an object rather used by the RequestCycle than a parent of
- pulling executor API from RequestHandlerStack to IRequestHandlerExecutor interface
- add asserting lines in RequestCycleListenerTest to cover the new callbacks

      was (Author: pedrosans):
    Request cycle on 1.5 maintain an stack of executions of request handlers, that is managed by RequestHandlerStack.
the patch:
- add those callback to IRequestCycleListener:
onRequestHandlerResolved
onExceptionRequestHandlerResolved
onRequestHandlerScheduled
- removes RequestHandlerStack from the RequestCycle hierarchy, since is it an object rather used by the RequestCycle than a parent of.
- add asserting lines in RequestCycleListenerTest to cover the new callbacks
  
> 1.5 equivalant of protected void WebRequestCycle.onRequestTargetSet(IRequestTarget requestTarget) is mising from AbstractRequestCycleListener
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3415
>                 URL: https://issues.apache.org/jira/browse/WICKET-3415
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5-RC1
>         Environment: Window XP SP 3, JDK 1.5.0_22, Eclipse 3.6.1, Tomcat 5.5.31
>            Reporter: Zhubin Salehi
>         Attachments: WICKET-3415.patch
>
>
> There is not method equivalent to WebRequestCycle.onRequestTargetSet(IRequestTarget requestTarget) in AbstractRequestCycleListener. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira