You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2016/09/21 00:43:32 UTC
[Impala-ASF-CR] IMPALA-4117: Factor simple scheduler test code into own files
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4486
Change subject: IMPALA-4117: Factor simple scheduler test code into own files
......................................................................
IMPALA-4117: Factor simple scheduler test code into own files
This change merely splits the helper classes from
simple-scheduler-test.cc into separate .h and .cc files. It does not
change the semantics of the code. Whitespace formatting has been done
with git-clang-format for any changed lines.
Change-Id: Id3a6b3336db175eb095cbeb7ec623a5957b77ccc
---
M be/src/scheduling/CMakeLists.txt
A be/src/scheduling/simple-scheduler-test-util.cc
A be/src/scheduling/simple-scheduler-test-util.h
M be/src/scheduling/simple-scheduler-test.cc
4 files changed, 1,010 insertions(+), 849 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/4486/1
--
To view, visit http://gerrit.cloudera.org:8080/4486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3a6b3336db175eb095cbeb7ec623a5957b77ccc
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-4117: Factor simple scheduler test code into own files
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4117: Factor simple scheduler test code into own files
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3a6b3336db175eb095cbeb7ec623a5957b77ccc
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4117: Factor simple scheduler test code into own files
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4117: Factor simple scheduler test code into own files
......................................................................
IMPALA-4117: Factor simple scheduler test code into own files
This change merely splits the helper classes from
simple-scheduler-test.cc into separate .h and .cc files. It does not
change the semantics of the code. Whitespace formatting has been done
with git-clang-format for any changed lines.
Change-Id: Id3a6b3336db175eb095cbeb7ec623a5957b77ccc
Reviewed-on: http://gerrit.cloudera.org:8080/4486
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Reviewed-by: Dan Hecht <dh...@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/scheduling/CMakeLists.txt
A be/src/scheduling/simple-scheduler-test-util.cc
A be/src/scheduling/simple-scheduler-test-util.h
M be/src/scheduling/simple-scheduler-test.cc
M be/src/scheduling/simple-scheduler.h
5 files changed, 1,015 insertions(+), 850 deletions(-)
Approvals:
Matthew Jacobs: Looks good to me, but someone else must approve
Internal Jenkins: Verified
Dan Hecht: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/4486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3a6b3336db175eb095cbeb7ec623a5957b77ccc
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-4117: Factor simple scheduler test code into own files
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4117: Factor simple scheduler test code into own files
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3a6b3336db175eb095cbeb7ec623a5957b77ccc
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4117: Factor simple scheduler test code into own files
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4117: Factor simple scheduler test code into own files
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3a6b3336db175eb095cbeb7ec623a5957b77ccc
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4117: Factor simple scheduler test code into own files
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4117: Factor simple scheduler test code into own files
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4486/1/be/src/scheduling/simple-scheduler-test-util.h
File be/src/scheduling/simple-scheduler-test-util.h:
PS1, Line 28: impala
Might be worth putting these classes in a sub-namespace since the names are super general sounding. That said, it shouldn't matter since I think this will only be pulled in by a one (maybe a few) tests? What do you think?
--
To view, visit http://gerrit.cloudera.org:8080/4486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3a6b3336db175eb095cbeb7ec623a5957b77ccc
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4117: Factor simple scheduler test code into own files
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has uploaded a new patch set (#2).
Change subject: IMPALA-4117: Factor simple scheduler test code into own files
......................................................................
IMPALA-4117: Factor simple scheduler test code into own files
This change merely splits the helper classes from
simple-scheduler-test.cc into separate .h and .cc files. It does not
change the semantics of the code. Whitespace formatting has been done
with git-clang-format for any changed lines.
Change-Id: Id3a6b3336db175eb095cbeb7ec623a5957b77ccc
---
M be/src/scheduling/CMakeLists.txt
A be/src/scheduling/simple-scheduler-test-util.cc
A be/src/scheduling/simple-scheduler-test-util.h
M be/src/scheduling/simple-scheduler-test.cc
M be/src/scheduling/simple-scheduler.h
5 files changed, 1,015 insertions(+), 850 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/4486/2
--
To view, visit http://gerrit.cloudera.org:8080/4486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id3a6b3336db175eb095cbeb7ec623a5957b77ccc
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
[Impala-ASF-CR] IMPALA-4117: Factor simple scheduler test code into own files
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-4117: Factor simple scheduler test code into own files
......................................................................
Patch Set 1:
(2 comments)
Thanks for the review, please see PS2.
http://gerrit.cloudera.org:8080/#/c/4486/1/be/src/scheduling/simple-scheduler-test-util.h
File be/src/scheduling/simple-scheduler-test-util.h:
PS1, Line 28: impala
> Might be worth putting these classes in a sub-namespace since the names are
I gave it a try and I think it looks cleaner. Even if these are only included by a few tests, whatever those tests include can also lead to name collisions.
PS1, Line 33: // Typedefs to make the rest of the code more readable.
: typedef std::string Hostname;
: typedef std::string IpAddr;
Removed those as they are now duplicated in network-util.h
--
To view, visit http://gerrit.cloudera.org:8080/4486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3a6b3336db175eb095cbeb7ec623a5957b77ccc
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes