You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/12 18:10:11 UTC
[GitHub] [camel-kafka-connector] cunningt opened a new pull request #576: ISSUE-146 Prevent the overwrite of existing classes unless they are @Generated annotated
cunningt opened a new pull request #576:
URL: https://github.com/apache/camel-kafka-connector/pull/576
Add readme text for the maven plugin and don't overwrite class if it is missing the @Generated string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] valdar commented on pull request #576: ISSUE-146 Prevent the overwrite of existing classes unless they are @Generated annotated
Posted by GitBox <gi...@apache.org>.
valdar commented on pull request #576:
URL: https://github.com/apache/camel-kafka-connector/pull/576#issuecomment-707314857
@cunningt thanks for the PR! while you remove the TODO can you mention issues in the commit description as fix #146 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] valdar merged pull request #576: ISSUE-146 Prevent the overwrite of existing classes unless they are @Generated annotated
Posted by GitBox <gi...@apache.org>.
valdar merged pull request #576:
URL: https://github.com/apache/camel-kafka-connector/pull/576
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] cunningt commented on a change in pull request #576: ISSUE-146 Prevent the overwrite of existing classes unless they are @Generated annotated
Posted by GitBox <gi...@apache.org>.
cunningt commented on a change in pull request #576:
URL: https://github.com/apache/camel-kafka-connector/pull/576#discussion_r503632417
##########
File path: tooling/camel-kafka-connector-generator-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/utils/MavenUtils.java
##########
@@ -272,7 +273,18 @@ public static void writeSourceIfChanged(JavaClass source, String fileName, boole
public static void writeSourceIfChanged(String source, String fileName, File baseDir, File javaFileHeader) throws MojoFailureException {
//TODO: Do not write class if a class already exist and has no @generated annotation.
Review comment:
Whoops! Removed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] valdar commented on a change in pull request #576: ISSUE-146 Prevent the overwrite of existing classes unless they are @Generated annotated
Posted by GitBox <gi...@apache.org>.
valdar commented on a change in pull request #576:
URL: https://github.com/apache/camel-kafka-connector/pull/576#discussion_r503499654
##########
File path: tooling/camel-kafka-connector-generator-maven-plugin/src/main/java/org/apache/camel/kafkaconnector/maven/utils/MavenUtils.java
##########
@@ -272,7 +273,18 @@ public static void writeSourceIfChanged(JavaClass source, String fileName, boole
public static void writeSourceIfChanged(String source, String fileName, File baseDir, File javaFileHeader) throws MojoFailureException {
//TODO: Do not write class if a class already exist and has no @generated annotation.
Review comment:
can you remove the TODO?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org