[GitHub] [incubator-superset] williaster commented on a change in pull request #7248: Fix refresh frequency

[GitBox <gi...@apache.org>]

williaster commented on a change in pull request #7248: Fix refresh frequency
URL: https://github.com/apache/incubator-superset/pull/7248#discussion_r273634927
 
 

 ##########
 File path: superset/assets/spec/javascripts/dashboard/components/HeaderActionsDropdown_spec.jsx
 ##########
 @@ -105,9 +105,9 @@ describe('HeaderActionsDropdown', () => {
       expect(wrapper.find(MenuItem)).toHaveLength(2);
     });
 
-    it('should render the RefreshIntervalModal', () => {
+    it('should not render the RefreshIntervalModal', () => {
 
 Review comment:
   should we add tests that assert it renders this in `editMode`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org