You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "reuvenlax (via GitHub)" <gi...@apache.org> on 2023/05/17 20:11:34 UTC
[GitHub] [beam] reuvenlax opened a new pull request, #26749: validate all records before publishing
reuvenlax opened a new pull request, #26749:
URL: https://github.com/apache/beam/pull/26749
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] closed pull request #26749: validate all records before publishing
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #26749: validate all records before publishing
URL: https://github.com/apache/beam/pull/26749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26749: validate all records before publishing
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26749:
URL: https://github.com/apache/beam/pull/26749#issuecomment-1649765595
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax commented on a diff in pull request #26749: validate all records before publishing
Posted by "reuvenlax (via GitHub)" <gi...@apache.org>.
reuvenlax commented on code in PR #26749:
URL: https://github.com/apache/beam/pull/26749#discussion_r1197196295
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java:
##########
@@ -521,9 +521,21 @@ long flush(
return ApiFutures.immediateFuture(AppendRowsResponse.newBuilder().build());
}
try {
- StreamAppendClient writeStream =
- Preconditions.checkStateNotNull(
- getAppendClientInfo(true, null).getStreamAppendClient());
+ AppendClientInfo appendInfo = Preconditions.checkStateNotNull(
+ getAppendClientInfo(true, null));
+ try {
+ for (ByteString bytes : c.protoRows.getSerializedRowsList()) {
+ DynamicMessage.parseFrom(appendInfo.getDescriptor(), bytes);
+ }
+ } catch (InvalidProtocolBufferException e) {
+ LOG.error("Failed to parse message destined to " + this.tableUrn + " STREAM " + this.streamName;
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26749: validate all records before publishing
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26749:
URL: https://github.com/apache/beam/pull/26749#issuecomment-1638067121
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26749: validate all records before publishing
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26749:
URL: https://github.com/apache/beam/pull/26749#issuecomment-1552083442
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] haganbmj commented on a diff in pull request #26749: validate all records before publishing
Posted by "haganbmj (via GitHub)" <gi...@apache.org>.
haganbmj commented on code in PR #26749:
URL: https://github.com/apache/beam/pull/26749#discussion_r1197178170
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java:
##########
@@ -521,9 +521,21 @@ long flush(
return ApiFutures.immediateFuture(AppendRowsResponse.newBuilder().build());
}
try {
- StreamAppendClient writeStream =
- Preconditions.checkStateNotNull(
- getAppendClientInfo(true, null).getStreamAppendClient());
+ AppendClientInfo appendInfo = Preconditions.checkStateNotNull(
+ getAppendClientInfo(true, null));
+ try {
+ for (ByteString bytes : c.protoRows.getSerializedRowsList()) {
+ DynamicMessage.parseFrom(appendInfo.getDescriptor(), bytes);
+ }
+ } catch (InvalidProtocolBufferException e) {
+ LOG.error("Failed to parse message destined to " + this.tableUrn + " STREAM " + this.streamName;
Review Comment:
Missing closing paren.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org