You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "winterhazel (via GitHub)" <gi...@apache.org> on 2025/12/18 03:56:59 UTC
[PR] Fix VM and volume metrics listing regression [cloudstack]
winterhazel opened a new pull request, #12284:
URL: https://github.com/apache/cloudstack/pull/12284
### Description
This PR fixes a regression in commit c8d44d9 that prevents non-admin accounts from listing the metrics of VMs and volumes that belong to a project.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [X] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Tests are still pending.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regression [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#issuecomment-3668425762
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regressions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#issuecomment-3672171785
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regressions [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regression [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#issuecomment-3668261586
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/12284?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 4.00%. Comparing base ([`ba26d95`](https://app.codecov.io/gh/apache/cloudstack/commit/ba26d95ad7c8c2f71029da22c4f82fc0fcc7c968?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c7989c0`](https://app.codecov.io/gh/apache/cloudstack/commit/c7989c0f24e83ac8e2f09059b06f1c3cc770abb2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (ba26d95) and HEAD (c7989c0). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (ba26d95) | HEAD (c7989c0) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.20 #12284 +/- ##
=============================================
- Coverage 16.22% 4.00% -12.23%
=============================================
Files 5657 402 -5255
Lines 498692 32686 -466006
Branches 60530 5817 -54713
=============================================
- Hits 80932 1309 -79623
+ Misses 408738 31222 -377516
+ Partials 9022 155 -8867
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/12284/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/12284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.00% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/12284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/12284?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regressions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#issuecomment-3672052496
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regression [cloudstack]
Posted by "winterhazel (via GitHub)" <gi...@apache.org>.
winterhazel commented on PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#issuecomment-3670148225
@kiranchavala thanks for testing :]
@DaanHoogland yup, I will do some refactoring (and some extra tests to be sure) before marking it as ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regressions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#issuecomment-3677511391
<b>[SF] Trillian test result (tid-15033)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 49197 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12284-t15033-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regressions [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#discussion_r2634278344
##########
plugins/metrics/src/main/java/org/apache/cloudstack/metrics/MetricsServiceImpl.java:
##########
@@ -244,25 +244,49 @@ public ListResponse<VolumeMetricsStatsResponse> searchForVolumeMetricsStats(List
return createVolumeMetricsStatsResponse(volumeList, volumeStatsList);
}
+ /**
+ * Outputs the parameters that should be used for access control in the query of a resource to
+ * {@code permittedAccounts} and {@code domainIdRecursiveListProject}.
+ * @param isIdProvided indicates whether any ID was provided to the command
+ */
+ private void buildBaseACLSearchParametersForMetrics(boolean isIdProvided, List<Long> permittedAccounts, Ternary<Long, Boolean,
+ Project.ListProjectResourcesCriteria> domainIdRecursiveListProject) {
+ Account caller = CallContext.current().getCallingAccount();
+ Account.Type callerType = caller.getType();
+
+ boolean recursive = AccountTypesWithRecursiveUsageAccess.contains(callerType);
+ domainIdRecursiveListProject.second(recursive);
+
+ // If no ID was provided, then the listing will skip project resources (null); otherwise, project resources should
+ // be listed as well (any long allows this)
+ Long id = isIdProvided ? 1L : null;
Review Comment:
is there side-effect when id is set to 1L ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regressions [cloudstack]
Posted by "winterhazel (via GitHub)" <gi...@apache.org>.
winterhazel commented on code in PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#discussion_r2634768861
##########
plugins/metrics/src/main/java/org/apache/cloudstack/metrics/MetricsServiceImpl.java:
##########
@@ -244,25 +244,49 @@ public ListResponse<VolumeMetricsStatsResponse> searchForVolumeMetricsStats(List
return createVolumeMetricsStatsResponse(volumeList, volumeStatsList);
}
+ /**
+ * Outputs the parameters that should be used for access control in the query of a resource to
+ * {@code permittedAccounts} and {@code domainIdRecursiveListProject}.
+ * @param isIdProvided indicates whether any ID was provided to the command
+ */
+ private void buildBaseACLSearchParametersForMetrics(boolean isIdProvided, List<Long> permittedAccounts, Ternary<Long, Boolean,
+ Project.ListProjectResourcesCriteria> domainIdRecursiveListProject) {
+ Account caller = CallContext.current().getCallingAccount();
+ Account.Type callerType = caller.getType();
+
+ boolean recursive = AccountTypesWithRecursiveUsageAccess.contains(callerType);
+ domainIdRecursiveListProject.second(recursive);
+
+ // If no ID was provided, then the listing will skip project resources (null); otherwise, project resources should
+ // be listed as well (any long allows this)
+ Long id = isIdProvided ? 1L : null;
Review Comment:
The value itself is not used, `com.cloud.user.AccountManagerImpl#buildACLSearchParameters` just checks whether the ID is null in order to decide whether project resources should be skipped or not, so no.
https://github.com/apache/cloudstack/blob/eb93f0105e315ab11afed16557c12f46e325ad53/server/src/main/java/com/cloud/user/AccountManagerImpl.java#L3376-L3378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regressions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#issuecomment-3674562456
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regressions [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#issuecomment-3674016342
> Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16092
we hit the github API limit @winterhazel , don’t worry about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regressions [cloudstack]
Posted by "winterhazel (via GitHub)" <gi...@apache.org>.
winterhazel commented on PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#issuecomment-3672073637
@DaanHoogland I extracted the code that builds the parameters to a method. Tests are also ok.
I noticed that there was another regression in which admins were not able to list the metrics of VMs/volumes belonging to projects via the `ids` parameter. It should be fixed now too.
<details>
<summary> Example </summary>
```
<before>
(admin) 🐢 > list virtualmachinesusagehistory id=69ecb2a6-dc91-46b9-a5d9-06e8222c5084
{
"count": 1,
"virtualmachine": [
{
"displayname": "k",
"id": "69ecb2a6-dc91-46b9-a5d9-06e8222c5084",
"name": "i-2-88-VM",
"stats": [
{
"cpuused": "0%",
"diskiopstotal": 0,
"diskioread": 0,
"diskiowrite": 0,
"diskkbsread": 0,
"diskkbswrite": 0,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 0,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:21:54+0000"
},
{
"cpuused": "20.77%",
"diskiopstotal": 835,
"diskioread": 640,
"diskiowrite": 195,
"diskkbsread": 10876,
"diskkbswrite": 1612,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 2,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:22:54+0000"
},
{
"cpuused": "13.52%",
"diskiopstotal": 0,
"diskioread": 0,
"diskiowrite": 0,
"diskkbsread": 0,
"diskkbswrite": 0,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 0,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:23:54+0000"
}
]
}
]
}
(admin) 🐢 > list virtualmachinesusagehistory ids=69ecb2a6-dc91-46b9-a5d9-06e8222c5084
<empty>
<with the patch>
(admin) 🐢 > list virtualmachinesusagehistory ids=69ecb2a6-dc91-46b9-a5d9-06e8222c5084
{
"count": 1,
"virtualmachine": [
{
"displayname": "k",
"id": "69ecb2a6-dc91-46b9-a5d9-06e8222c5084",
"name": "i-2-88-VM",
"stats": [
{
"cpuused": "0%",
"diskiopstotal": 0,
"diskioread": 0,
"diskiowrite": 0,
"diskkbsread": 0,
"diskkbswrite": 0,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 0,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:21:54+0000"
},
{
"cpuused": "20.77%",
"diskiopstotal": 835,
"diskioread": 640,
"diskiowrite": 195,
"diskkbsread": 10876,
"diskkbswrite": 1612,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 2,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:22:54+0000"
},
{
"cpuused": "13.52%",
"diskiopstotal": 0,
"diskioread": 0,
"diskiowrite": 0,
"diskkbsread": 0,
"diskkbswrite": 0,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 0,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:23:54+0000"
},
{
"cpuused": "60.96%",
"diskiopstotal": 1116,
"diskioread": 902,
"diskiowrite": 214,
"diskkbsread": 67400,
"diskkbswrite": 2040,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 0,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:24:55+0000"
},
{
"cpuused": "40.05%",
"diskiopstotal": 277,
"diskioread": 110,
"diskiowrite": 167,
"diskkbsread": 13304,
"diskkbswrite": 38524,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 0,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:25:56+0000"
},
{
"cpuused": "26.1%",
"diskiopstotal": 3,
"diskioread": 0,
"diskiowrite": 3,
"diskkbsread": 0,
"diskkbswrite": 16,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 0,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:26:58+0000"
},
{
"cpuused": "25.4%",
"diskiopstotal": 1,
"diskioread": 0,
"diskiowrite": 1,
"diskkbsread": 0,
"diskkbswrite": 4,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 0,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:27:59+0000"
},
{
"cpuused": "24.83%",
"diskiopstotal": 0,
"diskioread": 0,
"diskiowrite": 0,
"diskkbsread": 0,
"diskkbswrite": 0,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 0,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:29:02+0000"
},
{
"cpuused": "24.91%",
"diskiopstotal": 0,
"diskioread": 0,
"diskiowrite": 0,
"diskkbsread": 0,
"diskkbswrite": 0,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 0,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:30:04+0000"
},
{
"cpuused": "25.87%",
"diskiopstotal": 0,
"diskioread": 0,
"diskiowrite": 0,
"diskkbsread": 0,
"diskkbswrite": 0,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 0,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:31:09+0000"
},
{
"cpuused": "25.24%",
"diskiopstotal": 0,
"diskioread": 0,
"diskiowrite": 0,
"diskkbsread": 0,
"diskkbswrite": 0,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 0,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:32:11+0000"
},
{
"cpuused": "20.79%",
"diskiopstotal": 0,
"diskioread": 0,
"diskiowrite": 0,
"diskkbsread": 0,
"diskkbswrite": 0,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 0,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:33:12+0000"
},
{
"cpuused": "6.03%",
"diskiopstotal": 0,
"diskioread": 0,
"diskiowrite": 0,
"diskkbsread": 0,
"diskkbswrite": 0,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 0,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:34:13+0000"
},
{
"cpuused": "5.77%",
"diskiopstotal": 0,
"diskioread": 0,
"diskiowrite": 0,
"diskkbsread": 0,
"diskkbswrite": 0,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 0,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:35:13+0000"
},
{
"cpuused": "5.78%",
"diskiopstotal": 0,
"diskioread": 0,
"diskiowrite": 0,
"diskkbsread": 0,
"diskkbswrite": 0,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 0,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:36:13+0000"
},
{
"cpuused": "7.01%",
"diskiopstotal": 158,
"diskioread": 103,
"diskiowrite": 55,
"diskkbsread": 412,
"diskkbswrite": 472,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 0,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:37:13+0000"
},
{
"cpuused": "8.05%",
"diskiopstotal": 3,
"diskioread": 0,
"diskiowrite": 3,
"diskkbsread": 0,
"diskkbswrite": 16,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 0,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:38:14+0000"
},
{
"cpuused": "8.79%",
"diskiopstotal": 0,
"diskioread": 0,
"diskiowrite": 0,
"diskkbsread": 0,
"diskkbswrite": 0,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 0,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:39:14+0000"
},
{
"cpuused": "6.4%",
"diskiopstotal": 0,
"diskioread": 0,
"diskiowrite": 0,
"diskkbsread": 0,
"diskkbswrite": 0,
"memoryintfreekbs": 353728,
"memorykbs": 524288,
"memorytargetkbs": 524288,
"networkkbsread": 0,
"networkkbswrite": 0,
"networkread": "0.00 MiB",
"networkwrite": "0.00 MiB",
"timestamp": "2025-12-18T19:40:14+0000"
}
]
}
]
}
```
</details>
Also, passing the `ids` parameter to `listVolumesUsageHistory` was throwing an exception. I took the opportunity to fix this here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regression [cloudstack]
Posted by "winterhazel (via GitHub)" <gi...@apache.org>.
winterhazel commented on PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#issuecomment-3668238117
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regressions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#issuecomment-3672174163
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regressions [cloudstack]
Posted by "winterhazel (via GitHub)" <gi...@apache.org>.
winterhazel commented on PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#issuecomment-3672166073
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regressions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#issuecomment-3672111205
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regressions [cloudstack]
Posted by "winterhazel (via GitHub)" <gi...@apache.org>.
winterhazel commented on PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#issuecomment-3672049525
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regressions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#issuecomment-3675781411
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regression [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#issuecomment-3668240150
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regressions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#issuecomment-3672056162
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regressions [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#issuecomment-3672108281
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regressions [cloudstack]
Posted by "winterhazel (via GitHub)" <gi...@apache.org>.
winterhazel commented on PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#issuecomment-3672105357
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix VM and volume metrics listing regressions [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #12284:
URL: https://github.com/apache/cloudstack/pull/12284#issuecomment-3675777658
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org