You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/12/14 07:15:45 UTC

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #896: createnetwork: Fixing missing vlan parameter

rhtyd commented on a change in pull request #896:
URL: https://github.com/apache/cloudstack-primate/pull/896#discussion_r542158704



##########
File path: src/views/network/CreateNetwork.vue
##########
@@ -18,24 +18,24 @@
 <template>
   <div class="form-layout">
     <a-tabs defaultActiveKey="1" :animated="false">
-      <a-tab-pane :tab="$t('label.isolated')" key="1" v-if="this.isAdvancedZoneWithoutSGAvailable()">
-        <CreateIsolatedNetworkForm
+      <a-tab-pane :tab="$t('label.l2')" key="1">

Review comment:
       @davidjumani can the first network/tab be isolated, then l2 and then shared? Most people would want to see isolated by default; also this is reused in the deploy VM form.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org