[jira] [Commented] (FLINK-7483) BlobCache cleanup timer not reset after job re-registration

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135000#comment-16135000 ] 

ASF GitHub Bot commented on FLINK-7483:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/4568

    [FLINK-7483][blob] prevent cleanup of re-registered jobs

    ## What is the purpose of the change
    
    Since #4238, when a job is registered but was released before and the ref count hit `0`, its cleanup timeout was not reset. This fixes that and adds more reference-counter tests.
    
    ## Brief change log
    
    - reset the cleanup timeout after job re-registration
    - add a test for verifying the reference counters contain the expected values
    
    ## Verifying this change
    
    This change added a test for verifying reference counter values: `BlobCacheCleanupTest#testJobReferences`.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-6916-7057-hotfix2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4568.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4568
    
----
commit a0a5e2ebf999867462ed31257f30fd777f4fb5f4
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-08-21T08:36:56Z

    [FLINK-7483][blob] prevent cleanup of re-registered jobs
    
    When a job is registered, it may have been released before and we thus need to
    reset the cleanup timeout again.

----


> BlobCache cleanup timer not reset after job re-registration
> -----------------------------------------------------------
>
>                 Key: FLINK-7483
>                 URL: https://issues.apache.org/jira/browse/FLINK-7483
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Coordination, Network
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> Since FLINK-7057, the blob cache handles cleanup via {{registerJob}} and {{releaseJob}} calls where the latter sets a cleanup interval. {{registerJob}}, however, forgets to reset this if the job is re-registered again and so the job's blobs will be cleaned up although it is still used!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)