You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/02/01 04:21:58 UTC
[GitHub] [incubator-yunikorn-core] wilfred-s opened a new pull request #366: [YUNIKORN-1065] panic on node update
wilfred-s opened a new pull request #366:
URL: https://github.com/apache/incubator-yunikorn-core/pull/366
### What is this PR for?
If a node is not found during the update logging causes a panic as it
refers to the wrong object. Fixed another possible panic in node
processing in the context. Unit tests added to cover the panic cases.
Fixed layout and formatting issues in error messages and comments
### What type of PR is it?
* [X] - Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1065
### How should this be tested?
Unit tests cover all problem cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #366: [YUNIKORN-1065] panic on node update
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #366:
URL: https://github.com/apache/incubator-yunikorn-core/pull/366#issuecomment-1026675621
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/366?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#366](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/366?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b85b09) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/7bd90068beac7b572ca7c536ace1e3b103254b57?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7bd9006) will **increase** coverage by `0.58%`.
> The diff coverage is `52.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #366 +/- ##
==========================================
+ Coverage 67.57% 68.16% +0.58%
==========================================
Files 64 64
Lines 9009 9036 +27
==========================================
+ Hits 6088 6159 +71
+ Misses 2685 2640 -45
- Partials 236 237 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/metrics/event.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21ldHJpY3MvZXZlbnQuZ28=) | `71.05% <0.00%> (-8.36%)` | :arrow_down: |
| [pkg/metrics/init.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21ldHJpY3MvaW5pdC5nbw==) | `52.17% <0.00%> (-10.99%)` | :arrow_down: |
| [pkg/metrics/queue.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21ldHJpY3MvcXVldWUuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/metrics/scheduler.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL21ldHJpY3Mvc2NoZWR1bGVyLmdv) | `46.33% <28.57%> (-0.87%)` | :arrow_down: |
| [pkg/scheduler/context.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9jb250ZXh0Lmdv) | `28.75% <100.00%> (+11.22%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/366?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/366?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7bd9006...1b85b09](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/366?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s commented on pull request #366: [YUNIKORN-1065] panic on node update
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #366:
URL: https://github.com/apache/incubator-yunikorn-core/pull/366#issuecomment-1026541159
The unit test failure is caused by my change. The call to `metrics.Reset()` in the health tests does not work It is an empty function. The tests I added trigger a metrics update and thus cause the health tests to fail.
Implementing a proper rest of all metrics that can be reset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] craigcondit closed pull request #366: [YUNIKORN-1065] panic on node update
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #366:
URL: https://github.com/apache/incubator-yunikorn-core/pull/366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org