You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by jk...@apache.org on 2007/04/21 22:38:20 UTC
svn commit: r531104 -
/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/binding/ExpressionBinding.java
Author: jkuhnert
Date: Sat Apr 21 13:38:19 2007
New Revision: 531104
URL: http://svn.apache.org/viewvc?view=rev&rev=531104
Log:
Oops...Fixed failing unit test.
Modified:
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/binding/ExpressionBinding.java
Modified: tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/binding/ExpressionBinding.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/binding/ExpressionBinding.java?view=diff&rev=531104&r1=531103&r2=531104
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/binding/ExpressionBinding.java (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/binding/ExpressionBinding.java Sat Apr 21 13:38:19 2007
@@ -187,24 +187,27 @@
try
{
- if (_accessor == null && !_writeFailed) {
+ if (_accessor == null) {
_evaluator.writeCompiled(_root, _parsedExpression, value);
- // re-parse expression as compilation may be possible now that it potentially has a value
- try {
- _parsedExpression = (Node)_cache.getCompiledExpression(_root, _expression);
-
- _accessor = _parsedExpression.getAccessor();
- } catch (Throwable t) {
+ if (!_writeFailed) {
- // ignore re-read failures as they aren't supposed to be happening now anyways
- // and a more user friendly version will be available if someone actually calls
- // getObject
+ // re-parse expression as compilation may be possible now that it potentially has a value
+ try {
+ _parsedExpression = (Node)_cache.getCompiledExpression(_root, _expression);
+
+ _accessor = _parsedExpression.getAccessor();
+ } catch (Throwable t) {
+
+ // ignore re-read failures as they aren't supposed to be happening now anyways
+ // and a more user friendly version will be available if someone actually calls
+ // getObject
- // if writing fails then we're probably screwed...so don't do it again
- if (value != null)
- _writeFailed = true;
+ // if writing fails then we're probably screwed...so don't do it again
+ if (value != null)
+ _writeFailed = true;
+ }
}
} else
_evaluator.write(_root, _accessor, value);