[jira] [Commented] (THRIFT-2457) fbthrift float

["Roger Meier (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988139#comment-13988139 ] 

Roger Meier commented on THRIFT-2457:
-------------------------------------

[~jensg] A compiler supporting float will provide this warning:
{noformat}
use Thrift Libraries > 0.9.1 or latest version, they should handle float properly
{noformat}

a old compiler this:
{noformat}
thrift -gen cpp Float.thrift
[ERROR:Float.thrift:21] (last token was 'float')
Cannot use reserved language keyword: "float"
{noformat}

*API designers need to take care when using float data type and have to ensure that used libraries support it.*

I still believe it is worth to add float:
* compiler warning when using float or --with-float option
* test case within test/ThriftTest.thrift
* idl docs update
* proper error handling within the Thrift libraries and verify via make cross

patches are welcome!
-roger

> fbthrift float
> --------------
>
>                 Key: THRIFT-2457
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2457
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Build Process, C++ - Compiler, C++ - Library, Test Suite
>            Reporter: Roger Meier
>            Priority: Minor
>             Fix For: 1.0
>
>
> I'm interested into the fbthrift FLOAT data type.
> Which languages are supported?



--
This message was sent by Atlassian JIRA
(v6.2#6252)