You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by "Dongjoon Hyun (JIRA)" <ji...@apache.org> on 2015/10/30 08:12:27 UTC
[jira] [Updated] (REEF-892) Add javadocs and remove redundant
modifiers in Wake
[ https://issues.apache.org/jira/browse/REEF-892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dongjoon Hyun updated REEF-892:
-------------------------------
Description:
This issue addresses the followings.
* Add javadocs in reef-wake module.
* Remove redundant `public` in inner classes of `Clock` interface.
{code}
@NamedParameter(default_class = MissingStartHandlerHandler.class, doc = "Will be called upon the start event")
- public class StartHandler implements Name<Set<EventHandler<StartTime>>> {
+ class StartHandler implements Name<Set<EventHandler<StartTime>>> {
}
{code}
* Use diamond expressions.
{code}
- this.codec = new RemoteEventCodec<byte[]>(new ByteCodec());
+ this.codec = new RemoteEventCodec<>(new ByteCodec());
{code}
* Remove a few comment-out codes.
was:
This issue addresses the followings.
* Add javadocs in reef-wake module.*
* Remove redundant `public` in inner classes of `Clock` interface.*
{code}
@NamedParameter(default_class = MissingStartHandlerHandler.class, doc = "Will be called upon the start event")
- public class StartHandler implements Name<Set<EventHandler<StartTime>>> {
+ class StartHandler implements Name<Set<EventHandler<StartTime>>> {
}
{code}
* Use diamond expressions.*
{code}
- this.codec = new RemoteEventCodec<byte[]>(new ByteCodec());
+ this.codec = new RemoteEventCodec<>(new ByteCodec());
{code}
* Remove a few comment-out codes. *
> Add javadocs and remove redundant modifiers in Wake
> ----------------------------------------------------
>
> Key: REEF-892
> URL: https://issues.apache.org/jira/browse/REEF-892
> Project: REEF
> Issue Type: Task
> Components: Wake
> Reporter: Dongjoon Hyun
> Assignee: Dongjoon Hyun
> Priority: Minor
>
> This issue addresses the followings.
> * Add javadocs in reef-wake module.
> * Remove redundant `public` in inner classes of `Clock` interface.
> {code}
> @NamedParameter(default_class = MissingStartHandlerHandler.class, doc = "Will be called upon the start event")
> - public class StartHandler implements Name<Set<EventHandler<StartTime>>> {
> + class StartHandler implements Name<Set<EventHandler<StartTime>>> {
> }
> {code}
> * Use diamond expressions.
> {code}
> - this.codec = new RemoteEventCodec<byte[]>(new ByteCodec());
> + this.codec = new RemoteEventCodec<>(new ByteCodec());
> {code}
> * Remove a few comment-out codes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)