You are viewing a plain text version of this content. The canonical link for it is here.
Posted to torque-dev@db.apache.org by "Thomas Fox (Commented) (JIRA)" <ji...@apache.org> on 2012/03/04 14:58:00 UTC
[jira] [Commented] (TORQUE-110) unique name not parsed when
generating mysql (sql/base/mysql/unique.vm)
[ https://issues.apache.org/jira/browse/TORQUE-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221890#comment-13221890 ]
Thomas Fox commented on TORQUE-110:
-----------------------------------
fixed for mysql, also check other databases
> unique name not parsed when generating mysql (sql/base/mysql/unique.vm)
> -----------------------------------------------------------------------
>
> Key: TORQUE-110
> URL: https://issues.apache.org/jira/browse/TORQUE-110
> Project: Torque
> Issue Type: Bug
> Components: Generator
> Affects Versions: 3.3-RC3
> Environment: debian etch linux
> Reporter: Peter Frühberger
> Assignee: Thomas Fox
> Priority: Minor
>
> The following snippet of code:
> <unique name="NAME_IDX">
> <unique-column name="NAME"/>
> </unique>
> Schema:
> <!ELEMENT index (option*,index-column+)>
> <!ATTLIST index
> name CDATA #IMPLIED
> generates the following mysql code (the name is totally ignored), but the schema allows it.
> Create ...
> ...
> UNIQUE (NAME)
> );
> The unique index name (NAME_IDX) is missing, it should correctly be:
> Create ...
> UNIQUE NAME_IDX (NAME);
> );
> changing the unique.vm in sql/base/mysql/unique.vm from
> #foreach ($unique in $table.Unices)
> UNIQUE($unique.ColumnList),
> #end
> to
> #foreach ($unique in $table.Unices)
> UNIQUE $unique.Name ($unique.ColumnList),
> #end
> I think we have to change unique.vm to do the following semantics:
> if ("unique name" is specified) {
> unique $uniq.name ('column')
> }
> else {
> unique ('column')
> }
> We could also set the name whenever creating an sql unique column For example, if you have to maintain two different databases (i.e. oracle and mysql), both generated from the same xml file, you have probably written a tool which compares both databases. Oracle always uses an unique index name (afaik), mysql can do without, but comparisson from your tool failes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org