You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/09 17:48:44 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #1828: Unpin MIRI nightly
tustvold opened a new pull request, #1828:
URL: https://github.com/apache/arrow-rs/pull/1828
# Which issue does this PR close?
Closes #.
# Rationale for this change
The git history does not really indicate why this was pinned, so lets unpin and see what breaks. This is currently blocking #1822
# What changes are included in this PR?
Unpins miri version used in CI
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1828: Update MIRI pin
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1828:
URL: https://github.com/apache/arrow-rs/pull/1828#issuecomment-1151541660
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1828?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1828](https://codecov.io/gh/apache/arrow-rs/pull/1828?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb86bad) into [master](https://codecov.io/gh/apache/arrow-rs/commit/c92943cee1d93c234b4003c6ae5e4f68edc1e063?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c92943c) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head fb86bad differs from pull request most recent head e938c3d. Consider uploading reports for the commit e938c3d to get more accurate results
```diff
@@ Coverage Diff @@
## master #1828 +/- ##
=======================================
Coverage 83.45% 83.45%
=======================================
Files 200 200
Lines 56719 56719
=======================================
+ Hits 47334 47336 +2
+ Misses 9385 9383 -2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1828?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/1828/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `93.46% <0.00%> (-0.20%)` | :arrow_down: |
| [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/1828/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `65.79% <0.00%> (+0.37%)` | :arrow_up: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1828/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.98% <0.00%> (+0.45%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1828?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1828?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c92943c...e938c3d](https://codecov.io/gh/apache/arrow-rs/pull/1828?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #1828: Update MIRI pin
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #1828:
URL: https://github.com/apache/arrow-rs/pull/1828#discussion_r893885924
##########
.github/workflows/miri.yaml:
##########
@@ -26,19 +26,15 @@ jobs:
miri-checks:
name: MIRI
runs-on: ubuntu-latest
- strategy:
- matrix:
- arch: [amd64]
- rust: [nightly-2022-01-17]
Review Comment:
If we set this to `nightly`, would that make it slightly easier to pin again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1828: Update MIRI pin
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #1828:
URL: https://github.com/apache/arrow-rs/pull/1828#issuecomment-1151540135
If MIRI passes this one looks good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #1828: Update MIRI pin
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #1828:
URL: https://github.com/apache/arrow-rs/pull/1828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1828: Update MIRI pin
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #1828:
URL: https://github.com/apache/arrow-rs/pull/1828#discussion_r893888119
##########
.github/workflows/miri.yaml:
##########
@@ -26,19 +26,15 @@ jobs:
miri-checks:
name: MIRI
runs-on: ubuntu-latest
- strategy:
- matrix:
- arch: [amd64]
- rust: [nightly-2022-01-17]
Review Comment:
It's a one-line change either way so I don't think it really makes all that much difference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org