You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "ehoner (via GitHub)" <gi...@apache.org> on 2023/04/03 17:06:05 UTC

[GitHub] [samza] ehoner opened a new pull request, #1660: SAMZA-2776: Upgrade Azure libraries in module samza-azure.

ehoner opened a new pull request, #1660:
URL: https://github.com/apache/samza/pull/1660

   All changes are required by underlying changes to the updated libraries. None of the library changes required changes in Samza's public APIs. No unit tests were changed. Itemized description of underlying library changes is below.
   
   The file `samza-azure/samza-azure-dependencies.txt` was added and removed, intended for review/discussion purposes only \[[de23888](https://github.com/apache/samza/commit/de23888de31ef4d11206c6512f483e5bd13c6089)\]. 
   
   #### `EventHubClient.java`
   1.  Public method renamed
       1. `createSync` => `createFromConnectionStringSync`
       2. Azure/azure-sdk-for-java#4498
   2. Public method parameter changed
       1. `Exector` => `ScheduledExecutorService`
       2. (large refactor) - [Azure/azure-sdk-for-java/a8c2f43](https://github.com/Azure/azure-sdk-for-java/commit/a8c2f43c6fb3277b62e081e141f51e2720af3baf) -- see git-subtree-split: [e68c319](https://github.com/Azure/azure-sdk-for-java/commit/e68c319fdcbe6531ec54cb5d22eaf4b0d91f36da)
   
   
   #### `EventData.java`
   1. Added new public method.
       1. `void setSystemProperties(SystemProperties props);`
       2. Azure/azure-sdk-for-java#3474
       3. Implementation copied from `EventData.java`.
   2. Implements `Comparable<EventData>`
       1.  (large refactor) - [Azure/azure-sdk-for-java/e68c319](https://github.com/Azure/azure-sdk-for-java/commit/e68c319fdcbe6531ec54cb5d22eaf4b0d91f36da)
   
   
   #### `PartitionReceiver.java`
   1. Removed public APIs
       1. `void setPrefetchCount(final int prefetchCount) throws EventHubException;`
       2. (large refactor) - [Azure/azure-sdk-for-java/e68c319](https://github.com/Azure/azure-sdk-for-java/commit/e68c319fdcbe6531ec54cb5d22eaf4b0d91f36da)
       3. Requires use of `RecieverOptions` object (no functionality lost).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] ehoner commented on pull request #1660: SAMZA-2776: Upgrade Azure libraries in module samza-azure.

Posted by "ehoner (via GitHub)" <gi...@apache.org>.
ehoner commented on PR #1660:
URL: https://github.com/apache/samza/pull/1660#issuecomment-1584767485

   @hshukla 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] ehoner commented on a diff in pull request #1660: SAMZA-2776: Upgrade Azure libraries in module samza-azure.

Posted by "ehoner (via GitHub)" <gi...@apache.org>.
ehoner commented on code in PR #1660:
URL: https://github.com/apache/samza/pull/1660#discussion_r1228789636


##########
samza-azure/src/main/java/org/apache/samza/system/eventhub/consumer/EventHubSystemConsumer.java:
##########
@@ -280,13 +281,13 @@ private synchronized void initializeEventHubsManagers() {
         } else {
           // EventHub will return the first message AFTER the offset that was specified in the fetch request.
           // If no such offset exists Eventhub will return an error.
+          ReceiverOptions receiverOptions = new ReceiverOptions();
+          receiverOptions.setPrefetchCount(prefetchCount);

Review Comment:
   Value is unused.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] atoomula merged pull request #1660: SAMZA-2776: Upgrade Azure libraries in module samza-azure.

Posted by "atoomula (via GitHub)" <gi...@apache.org>.
atoomula merged PR #1660:
URL: https://github.com/apache/samza/pull/1660


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] ehoner commented on a diff in pull request #1660: SAMZA-2776: Upgrade Azure libraries in module samza-azure.

Posted by "ehoner (via GitHub)" <gi...@apache.org>.
ehoner commented on code in PR #1660:
URL: https://github.com/apache/samza/pull/1660#discussion_r1228789636


##########
samza-azure/src/main/java/org/apache/samza/system/eventhub/consumer/EventHubSystemConsumer.java:
##########
@@ -280,13 +281,13 @@ private synchronized void initializeEventHubsManagers() {
         } else {
           // EventHub will return the first message AFTER the offset that was specified in the fetch request.
           // If no such offset exists Eventhub will return an error.
+          ReceiverOptions receiverOptions = new ReceiverOptions();
+          receiverOptions.setPrefetchCount(prefetchCount);

Review Comment:
   Value is used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org