You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by "Matthias Reischenbacher (JIRA)" <ji...@apache.org> on 2019/07/27 13:31:00 UTC

[jira] [Resolved] (FOP-2875) [PATCH] basic-link to a file or an embedded file breaks if filename contains a parenthesis

     [ https://issues.apache.org/jira/browse/FOP-2875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Reischenbacher resolved FOP-2875.
------------------------------------------
    Resolution: Fixed

Thanks for your patch, [~esclim]! I combined it with a fix for attachment name collisions. When using two attachment with similar names, that contain non-ascii chars e.g. täst, töst, only one of the attachments was added to the PDF file.

http://svn.apache.org/viewvc?view=revision&revision=1863870

> [PATCH]  basic-link to a file or an embedded file breaks if filename contains a parenthesis
> -------------------------------------------------------------------------------------------
>
>                 Key: FOP-2875
>                 URL: https://issues.apache.org/jira/browse/FOP-2875
>             Project: FOP
>          Issue Type: Bug
>          Components: renderer/pdf
>            Reporter: Eric Lim
>            Assignee: Matthias Reischenbacher
>            Priority: Minor
>         Attachments: paren3.patch, test-case.fo
>
>
> The following FO snippet
> {code:java}
> <fo:basic-link external-destination="embedded-file:some(paren.pdf">The link to some file</fo:basic-link>{code}
> produces the following PDF snippet
> {code:java}
> <<
> /S /JavaScript
> /JS (this.exportDataObject({cName:"some(paren.pdf", nLaunch:2});)
> >>{code}
> This PDF action is broken because the parenthesis are not escaped.
> The correct output should be
> {code:java}
> <<
> /S /JavaScript
> /JS (this.exportDataObject\({cName:"some\(paren.pdf", nLaunch:2}\);)
> >>{code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)