[jira] [Commented] (KAFKA-4991) KerberosLogin#login should probably be synchronized

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-4991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312781#comment-16312781 ] 

ASF GitHub Bot commented on KAFKA-4991:
---------------------------------------

omkreddy opened a new pull request #4394: KAFKA-4991: Resolve findbugs warnings in KerberosLogin
URL: https://github.com/apache/kafka/pull/4394
 
 
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> KerberosLogin#login should probably be synchronized
> ---------------------------------------------------
>
>                 Key: KAFKA-4991
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4991
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Colin P. McCabe
>            Assignee: Colin P. McCabe
>              Labels: newbie
>             Fix For: 1.1.0
>
>
> KerberosLogin#login should probably be synchronized, since it is modifying {{loginContext}} and {{lastLogin}}, which are normally only accessed under the lock.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)