You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ra...@apache.org on 2018/09/16 11:52:30 UTC
[cordova-cli] branch master updated: Stub telemetry calls during
all tests (#327)
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-cli.git
The following commit(s) were added to refs/heads/master by this push:
new f8ed27c Stub telemetry calls during all tests (#327)
f8ed27c is described below
commit f8ed27c6d420b978b569dc8966a788164992362f
Author: Raphael von der Grün <ra...@gmail.com>
AuthorDate: Sun Sep 16 13:52:26 2018 +0200
Stub telemetry calls during all tests (#327)
This change makes _all_ `describe` blocks in cli.spec descendants of a
common top-level `describe` block which stubs any critical telemetry
methods.
Thus we ensure that telemetry is never collected during test runs.
---
spec/cli.spec.js | 216 +++++++++++++++++++++++++++----------------------------
1 file changed, 108 insertions(+), 108 deletions(-)
diff --git a/spec/cli.spec.js b/spec/cli.spec.js
index fcf9a6c..172dd17 100644
--- a/spec/cli.spec.js
+++ b/spec/cli.spec.js
@@ -360,141 +360,141 @@ describe('cordova cli', () => {
});
});
});
-});
-describe('platform', () => {
+ describe('platform', () => {
- beforeEach(() => {
- spyOn(cordova, 'platform').and.returnValue(Promise.resolve());
- logger.setLevel('error');
- });
+ beforeEach(() => {
+ spyOn(cordova, 'platform').and.returnValue(Promise.resolve());
+ logger.setLevel('error');
+ });
- it('Test #034 : (add) autosave is the default setting for platform add', () => {
- return cli(['node', 'cordova', 'platform', 'add', 'ios']).then(() => {
- expect(cordova.platform).toHaveBeenCalledWith(
- 'add',
- ['ios'],
- jasmine.any(Object)
- );
- const opts = cordova.platform.calls.argsFor(0)[2];
- expect(opts.save).toBe(true);
+ it('Test #034 : (add) autosave is the default setting for platform add', () => {
+ return cli(['node', 'cordova', 'platform', 'add', 'ios']).then(() => {
+ expect(cordova.platform).toHaveBeenCalledWith(
+ 'add',
+ ['ios'],
+ jasmine.any(Object)
+ );
+ const opts = cordova.platform.calls.argsFor(0)[2];
+ expect(opts.save).toBe(true);
+ });
});
- });
- it('Test #035 : (add) platform is not saved when --nosave is passed in', () => {
- return cli(['node', 'cordova', 'platform', 'add', 'ios', '--nosave']).then(() => {
- expect(cordova.platform).toHaveBeenCalledWith(
- 'add',
- ['ios'],
- jasmine.any(Object)
- );
- const opts = cordova.platform.calls.argsFor(0)[2];
- expect(opts.save).toBe(false);
+ it('Test #035 : (add) platform is not saved when --nosave is passed in', () => {
+ return cli(['node', 'cordova', 'platform', 'add', 'ios', '--nosave']).then(() => {
+ expect(cordova.platform).toHaveBeenCalledWith(
+ 'add',
+ ['ios'],
+ jasmine.any(Object)
+ );
+ const opts = cordova.platform.calls.argsFor(0)[2];
+ expect(opts.save).toBe(false);
+ });
});
- });
- it('Test #036 : (remove) autosave is the default setting for platform remove', () => {
- return cli(['node', 'cordova', 'platform', 'remove', 'ios']).then(() => {
- expect(cordova.platform).toHaveBeenCalledWith(
- 'remove',
- ['ios'],
- jasmine.any(Object)
- );
- const opts = cordova.platform.calls.argsFor(0)[2];
- expect(opts.save).toBe(true);
+ it('Test #036 : (remove) autosave is the default setting for platform remove', () => {
+ return cli(['node', 'cordova', 'platform', 'remove', 'ios']).then(() => {
+ expect(cordova.platform).toHaveBeenCalledWith(
+ 'remove',
+ ['ios'],
+ jasmine.any(Object)
+ );
+ const opts = cordova.platform.calls.argsFor(0)[2];
+ expect(opts.save).toBe(true);
+ });
});
- });
- it('Test #037 : (remove) platform is not removed when --nosave is passed in', () => {
- return cli(['node', 'cordova', 'platform', 'remove', 'ios', '--nosave']).then(() => {
- expect(cordova.platform).toHaveBeenCalledWith(
- 'remove',
- ['ios'],
- jasmine.any(Object)
- );
- const opts = cordova.platform.calls.argsFor(0)[2];
- expect(opts.save).toBe(false);
+ it('Test #037 : (remove) platform is not removed when --nosave is passed in', () => {
+ return cli(['node', 'cordova', 'platform', 'remove', 'ios', '--nosave']).then(() => {
+ expect(cordova.platform).toHaveBeenCalledWith(
+ 'remove',
+ ['ios'],
+ jasmine.any(Object)
+ );
+ const opts = cordova.platform.calls.argsFor(0)[2];
+ expect(opts.save).toBe(false);
+ });
});
});
-});
-describe('config', () => {
- let clirevert, confrevert, editorArgs, confHolder;
- const cordovaConfig = {};
-
- const confMock = {
- set (key, value) {
- cordovaConfig[key] = value;
- },
- del (key) {
- delete cordovaConfig[key];
- },
- path () {
- confHolder = 'Pathcalled';
- return 'some/path/cordova-config.json';
- },
- get (key) {
- confHolder = cordovaConfig[key];
- return cordovaConfig[key];
- }
- };
-
- beforeEach(() => {
- clirevert = cli.__set__('editor', (path1, cb) => {
- editorArgs = path1();
- cb();
- });
+ describe('config', () => {
+ let clirevert, confrevert, editorArgs, confHolder;
+ const cordovaConfig = {};
+
+ const confMock = {
+ set (key, value) {
+ cordovaConfig[key] = value;
+ },
+ del (key) {
+ delete cordovaConfig[key];
+ },
+ path () {
+ confHolder = 'Pathcalled';
+ return 'some/path/cordova-config.json';
+ },
+ get (key) {
+ confHolder = cordovaConfig[key];
+ return cordovaConfig[key];
+ }
+ };
- confrevert = cli.__set__('conf', confMock);
- logger.setLevel('error');
- // spyOn(console, 'log');
- });
+ beforeEach(() => {
+ clirevert = cli.__set__('editor', (path1, cb) => {
+ editorArgs = path1();
+ cb();
+ });
- afterEach(() => {
- clirevert();
- confrevert();
- confHolder = undefined;
- });
+ confrevert = cli.__set__('conf', confMock);
+ logger.setLevel('error');
+ // spyOn(console, 'log');
+ });
- it('Test#042 : config set autosave is called with true', () => {
- return cli(['node', 'cordova', 'config', 'set', 'autosave', 'true', '--silent']).then(() => {
- expect(cordovaConfig.autosave).toBe('true');
+ afterEach(() => {
+ clirevert();
+ confrevert();
+ confHolder = undefined;
});
- });
- it('Test#043 : config delete autosave is called', () => {
- return cli(['node', 'cordova', 'config', 'delete', 'autosave']).then(() => {
- expect(cordovaConfig.autosave).toBeUndefined();
+ it('Test#042 : config set autosave is called with true', () => {
+ return cli(['node', 'cordova', 'config', 'set', 'autosave', 'true', '--silent']).then(() => {
+ expect(cordovaConfig.autosave).toBe('true');
+ });
});
- });
- it('Test#044 : config set is called even without value, defaults to true', () => {
- return cli(['node', 'cordova', 'config', 'set', 'autosave']).then(() => {
- expect(cordovaConfig.autosave).toBe(true);
+ it('Test#043 : config delete autosave is called', () => {
+ return cli(['node', 'cordova', 'config', 'delete', 'autosave']).then(() => {
+ expect(cordovaConfig.autosave).toBeUndefined();
+ });
});
- });
- it('Test #045 : config get is called', () => {
- return cli(['node', 'cordova', 'config', 'get', 'autosave']).then(() => {
- expect(confHolder).toBe(true);
+ it('Test#044 : config set is called even without value, defaults to true', () => {
+ return cli(['node', 'cordova', 'config', 'set', 'autosave']).then(() => {
+ expect(cordovaConfig.autosave).toBe(true);
+ });
});
- });
- it('Test #046 : config edit is called', () => {
- return cli(['node', 'cordova', 'config', 'edit']).then(() => {
- expect(path.basename(editorArgs)).toEqual('cordova-config.json');
- expect(confHolder).toEqual('Pathcalled');
+ it('Test #045 : config get is called', () => {
+ return cli(['node', 'cordova', 'config', 'get', 'autosave']).then(() => {
+ expect(confHolder).toBe(true);
+ });
});
- });
- it('Test #047 : config ls is called', () => {
- spyOn(fs, 'readFile').and.callFake((confPath, cb) => {
- confHolder = confPath();
+ it('Test #046 : config edit is called', () => {
+ return cli(['node', 'cordova', 'config', 'edit']).then(() => {
+ expect(path.basename(editorArgs)).toEqual('cordova-config.json');
+ expect(confHolder).toEqual('Pathcalled');
+ });
});
- return cli(['node', 'cordova', 'config', 'ls']).then(() => {
- expect(path.basename(confHolder)).toEqual('cordova-config.json');
+ it('Test #047 : config ls is called', () => {
+ spyOn(fs, 'readFile').and.callFake((confPath, cb) => {
+ confHolder = confPath();
+ });
+
+ return cli(['node', 'cordova', 'config', 'ls']).then(() => {
+ expect(path.basename(confHolder)).toEqual('cordova-config.json');
+ });
});
- });
+ });
});
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org