You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Ashwani Raina (Code Review)" <ge...@cloudera.org> on 2025/08/19 13:50:06 UTC
[kudu-CR] [maintenance] fix typo and alignment mismatch
Ashwani Raina has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23307
Change subject: [maintenance] fix typo and alignment mismatch
......................................................................
[maintenance] fix typo and alignment mismatch
Correct the typo in 'rows_writed_per_sec_for_hot_tablets' and fix some
alignments to make it consistent with what is followed at other places.
This changelist doesn't contain any functional modifications.
Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd
---
M src/kudu/tablet/tablet.cc
1 file changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/23307/1
--
To view, visit http://gerrit.cloudera.org:8080/23307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd
Gerrit-Change-Number: 23307
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
[kudu-CR] [maintenance] fix typo and alignment mismatch
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23307 )
Change subject: [maintenance] fix typo and alignment mismatch
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1698/
--
To view, visit http://gerrit.cloudera.org:8080/23307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd
Gerrit-Change-Number: 23307
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 19 Aug 2025 13:50:13 +0000
Gerrit-HasComments: No
[kudu-CR] [maintenance] fix typo and alignment mismatch
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23307 )
Change subject: [maintenance] fix typo and alignment mismatch
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23307/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23307/1//COMMIT_MSG@12
PS1, Line 12: This changelist doesn't contain any functional modifications.
> In fact, this update changes the name of the flag exposed to the users, so
I think once we update the docs with the next release, this will be reflected in the docs. Probably we can add a note in the release notes about this change.
--
To view, visit http://gerrit.cloudera.org:8080/23307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd
Gerrit-Change-Number: 23307
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 20 Aug 2025 00:02:06 +0000
Gerrit-HasComments: Yes
[kudu-CR] [maintenance] fix typo and alignment mismatch
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23307 )
Change subject: [maintenance] fix typo and alignment mismatch
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23307/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23307/1//COMMIT_MSG@12
PS1, Line 12: This changelist doesn't contain any functional modifications.
> I think once we update the docs with the next release, this will be reflect
Yes, that seems to be a reasonable approach -- document this as a minor breaking change to provide a heads-up to people who might be using this flag already. The flag has been around since Kudu 1.13.0 release (about 5 years as of time of writing this comment).
Definitely, this update is good for next minor release (i.e. 1.19.0). However, I'm not exactly sure about including this into 1.18.1 maintenance release.
What do you guys think?
--
To view, visit http://gerrit.cloudera.org:8080/23307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd
Gerrit-Change-Number: 23307
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 20 Aug 2025 04:58:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] [maintenance] fix typo and alignment mismatch
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23307 )
Change subject: [maintenance] fix typo and alignment mismatch
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/23307/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23307/1//COMMIT_MSG@12
PS1, Line 12: This changelist doesn't contain any functional modifications.
In fact, this update changes the name of the flag exposed to the users, so anybody who happen to use the old/mispelled name of the flag will be affected.
http://gerrit.cloudera.org:8080/#/c/23307/1/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:
http://gerrit.cloudera.org:8080/#/c/23307/1/src/kudu/tablet/tablet.cc@195
PS1, Line 195: TAG_FLAG(rows_written_per_sec_for_hot_tablets, experimental);
Do you have any concerns with the backward-compatibility of this update?
--
To view, visit http://gerrit.cloudera.org:8080/23307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd
Gerrit-Change-Number: 23307
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 19 Aug 2025 16:04:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] [maintenance] fix typo and alignment mismatch
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/23307 )
Change subject: [maintenance] fix typo and alignment mismatch
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/23307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd
Gerrit-Change-Number: 23307
Gerrit-PatchSet: 2
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Sep 2025 07:43:39 +0000
Gerrit-HasComments: No
[kudu-CR] [maintenance] fix typo and alignment mismatch
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23307 )
Change subject: [maintenance] fix typo and alignment mismatch
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1698/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd
Gerrit-Change-Number: 23307
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 19 Aug 2025 15:34:23 +0000
Gerrit-HasComments: No
[kudu-CR] [maintenance] fix typo and alignment mismatch
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23307 )
Change subject: [maintenance] fix typo and alignment mismatch
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23307/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23307/1//COMMIT_MSG@12
PS1, Line 12: This changelist doesn't contain any functional modifications.
> > I agree with Abhishek.
Yes, let's keep it out of 1.18.1 release to avoid any surprises. We can have in the master branch and it will be boiled down to the next minor release.
--
To view, visit http://gerrit.cloudera.org:8080/23307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd
Gerrit-Change-Number: 23307
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 26 Aug 2025 00:07:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] [maintenance] fix typo and alignment mismatch
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23307 )
Change subject: [maintenance] fix typo and alignment mismatch
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1849/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd
Gerrit-Change-Number: 23307
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 24 Sep 2025 10:13:54 +0000
Gerrit-HasComments: No
[kudu-CR] [maintenance] fix typo and alignment mismatch
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23307 )
Change subject: [maintenance] fix typo and alignment mismatch
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd
Gerrit-Change-Number: 23307
Gerrit-PatchSet: 2
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Thu, 25 Sep 2025 07:42:43 +0000
Gerrit-HasComments: No
[kudu-CR] [maintenance] fix typo and alignment mismatch
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23307 )
Change subject: [maintenance] fix typo and alignment mismatch
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd
Gerrit-Change-Number: 23307
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 21:37:42 +0000
Gerrit-HasComments: No
[kudu-CR] [maintenance] fix typo and alignment mismatch
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23307 )
Change subject: [maintenance] fix typo and alignment mismatch
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23307/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23307/1//COMMIT_MSG@12
PS1, Line 12: This changelist doesn't contain any functional modifications.
> I agree with Abhishek.
> Additionally, I think there is little to no chance that users are modifying this flag. The flag is too internal (applicable to maintenance ops i.e. flush or compaction) from the user perspective. On top of that this is an experimental flag.
>
> That said, I also agree that even with remote chance, the user may still get impacted with this change.
>
> Even though this is fixing any functional issue, I would prefer to have this change in 1.18.1 to ensure correctness and documentation accuracy and that kind of fits into maintenance release criteria as well.
I meant - "this is not fixing any functional issue"
>
> Since Abhishek is looking after the release and I am not sure how much effort it would entail, I will let him take the call. I would be fine if we decide to include it in next minor release.
--
To view, visit http://gerrit.cloudera.org:8080/23307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd
Gerrit-Change-Number: 23307
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 20 Aug 2025 08:30:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] [maintenance] fix typo and alignment mismatch
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23307 )
Change subject: [maintenance] fix typo and alignment mismatch
......................................................................
[maintenance] fix typo and alignment mismatch
Correct the typo in 'rows_writed_per_sec_for_hot_tablets' and fix some
alignments to make it consistent with what is followed at other places.
This changelist doesn't contain any functional modifications.
Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd
Reviewed-on: http://gerrit.cloudera.org:8080/23307
Tested-by: Kudu Jenkins
Reviewed-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
---
M src/kudu/tablet/tablet.cc
1 file changed, 10 insertions(+), 10 deletions(-)
Approvals:
Kudu Jenkins: Verified
Marton Greber: Looks good to me, approved
Zoltan Chovan: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/23307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd
Gerrit-Change-Number: 23307
Gerrit-PatchSet: 3
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [maintenance] fix typo and alignment mismatch
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23307 )
Change subject: [maintenance] fix typo and alignment mismatch
......................................................................
Patch Set 2: Verified+1
Build Successful
http://jenkins.kudu.apache.org/job/pre_commit/1851/ : SUCCESS
--
To view, visit http://gerrit.cloudera.org:8080/23307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd
Gerrit-Change-Number: 23307
Gerrit-PatchSet: 2
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 24 Sep 2025 11:26:30 +0000
Gerrit-HasComments: No
[kudu-CR] [maintenance] fix typo and alignment mismatch
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23307 )
Change subject: [maintenance] fix typo and alignment mismatch
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/23307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd
Gerrit-Change-Number: 23307
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 19:43:52 +0000
Gerrit-HasComments: No
[kudu-CR] [maintenance] fix typo and alignment mismatch
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23307 )
Change subject: [maintenance] fix typo and alignment mismatch
......................................................................
Patch Set 1: -Verified
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1849/
--
To view, visit http://gerrit.cloudera.org:8080/23307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd
Gerrit-Change-Number: 23307
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 24 Sep 2025 08:41:27 +0000
Gerrit-HasComments: No
[kudu-CR] [maintenance] fix typo and alignment mismatch
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23307 )
Change subject: [maintenance] fix typo and alignment mismatch
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1851/
--
To view, visit http://gerrit.cloudera.org:8080/23307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd
Gerrit-Change-Number: 23307
Gerrit-PatchSet: 2
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 24 Sep 2025 08:48:47 +0000
Gerrit-HasComments: No
[kudu-CR] [maintenance] fix typo and alignment mismatch
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23307 )
Change subject: [maintenance] fix typo and alignment mismatch
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/23307/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23307/1//COMMIT_MSG@12
PS1, Line 12: This changelist doesn't contain any functional modifications.
> Yes, that seems to be a reasonable approach -- document this as a minor bre
I agree with Abhishek.
Additionally, I think there is little to no chance that users are modifying this flag. The flag is too internal (applicable to maintenance ops i.e. flush or compaction) from the user perspective. On top of that this is an experimental flag.
That said, I also agree that even with remote chance, the user may still get impacted with this change.
Even though this is fixing any functional issue, I would prefer to have this change in 1.18.1 to ensure correctness and documentation accuracy and that kind of fits into maintenance release criteria as well.
Since Abhishek is looking after the release and I am not sure how much effort it would entail, I will let him take the call. I would be fine if we decide to include it in next minor release.
http://gerrit.cloudera.org:8080/#/c/23307/1/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:
http://gerrit.cloudera.org:8080/#/c/23307/1/src/kudu/tablet/tablet.cc@195
PS1, Line 195: TAG_FLAG(rows_written_per_sec_for_hot_tablets, experimental);
> Do you have any concerns with the backward-compatibility of this update?
Nothing other than what is covered in https://gerrit.cloudera.org/#/c/23307/1//COMMIT_MSG@12
I would be surprised if users are actively using this flag either manually or via some deployment scripts.
--
To view, visit http://gerrit.cloudera.org:8080/23307
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd
Gerrit-Change-Number: 23307
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 20 Aug 2025 07:43:38 +0000
Gerrit-HasComments: Yes