You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/19 03:43:04 UTC
[GitHub] [apisix] tzssangglass opened a new pull request, #7080: chore(ci): apt update before install
tzssangglass opened a new pull request, #7080:
URL: https://github.com/apache/apisix/pull/7080
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes # (issue)
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #7080: chore(ci): apt update before install
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #7080:
URL: https://github.com/apache/apisix/pull/7080#discussion_r876687354
##########
ci/linux_openresty_common_runner.sh:
##########
@@ -101,6 +101,10 @@ after_success() {
echo "done"
}
+linux_get_dependencies() {
+ install_dependencies
Review Comment:
We can put this in each runner.sh's `do_install`? So there is no need to put `sudo ./ci/${{ matrix.os_name }}_runner.sh linux_get_dependencies` in each workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #7080: chore(ci): apt update before install
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #7080:
URL: https://github.com/apache/apisix/pull/7080#discussion_r876572888
##########
.github/workflows/tars-ci.yml:
##########
@@ -48,6 +48,7 @@ jobs:
- name: Linux Install
run: |
+ sudo apt-get update
sudo apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev
Review Comment:
Would be better to put repeated commands in https://github.com/apache/apisix/blob/master/ci/common.sh?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a diff in pull request #7080: chore(ci): apt update before install
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on code in PR #7080:
URL: https://github.com/apache/apisix/pull/7080#discussion_r876594043
##########
.github/workflows/tars-ci.yml:
##########
@@ -48,6 +48,7 @@ jobs:
- name: Linux Install
run: |
+ sudo apt-get update
sudo apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev
Review Comment:
common.sh is not a bash script, just a file, do we need to change its positioning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a diff in pull request #7080: chore(ci): apt update before install
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on code in PR #7080:
URL: https://github.com/apache/apisix/pull/7080#discussion_r876594043
##########
.github/workflows/tars-ci.yml:
##########
@@ -48,6 +48,7 @@ jobs:
- name: Linux Install
run: |
+ sudo apt-get update
sudo apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev
Review Comment:
update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #7080: chore(ci): apt update before install
Posted by GitBox <gi...@apache.org>.
spacewander merged PR #7080:
URL: https://github.com/apache/apisix/pull/7080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org