You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/30 19:27:41 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request, #4037: Fix most benchmark query regressions
andygrove opened a new pull request, #4037:
URL: https://github.com/apache/arrow-datafusion/pull/4037
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes https://github.com/apache/arrow-datafusion/issues/4026
Closes https://github.com/apache/arrow-datafusion/issues/4025
Closes https://github.com/apache/arrow-datafusion/issues/4023
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
We cannot use decimal types in the benchmark until they are fully implemented.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
- Revert to Float64 in benchmark schema
- Update tests to tolerate small rounding differences as a temporary measure until we move to decimals
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #4037: Fix most benchmark query regressions
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #4037:
URL: https://github.com/apache/arrow-datafusion/pull/4037#discussion_r1008920714
##########
benchmarks/src/tpch.rs:
##########
@@ -38,12 +40,17 @@ pub const TPCH_TABLES: &[&str] = &[
"part", "supplier", "partsupp", "customer", "orders", "lineitem", "nation", "region",
];
+fn decimal_type(_p: u8, _s: u8) -> DataType {
+ // TODO use decimal_type(p, s) once Decimal is fully supported
+ // https://github.com/apache/arrow-datafusion/issues/3523
+ DataType::Float64
+}
Review Comment:
We could also add a CLI option to switch between float and decimal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove closed pull request #4037: Fix most benchmark query regressions
Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #4037: Fix most benchmark query regressions
URL: https://github.com/apache/arrow-datafusion/pull/4037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #4037: Fix most benchmark query regressions
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #4037:
URL: https://github.com/apache/arrow-datafusion/pull/4037#discussion_r1008914877
##########
benchmarks/src/tpch.rs:
##########
@@ -38,12 +40,17 @@ pub const TPCH_TABLES: &[&str] = &[
"part", "supplier", "partsupp", "customer", "orders", "lineitem", "nation", "region",
];
+fn decimal_type(_p: u8, _s: u8) -> DataType {
+ // TODO use decimal_type(p, s) once Decimal is fully supported
+ // https://github.com/apache/arrow-datafusion/issues/3523
+ DataType::Float64
+}
Review Comment:
When we're ready to try decimal again, we just need to update this one function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #4037: Fix most benchmark query regressions
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #4037:
URL: https://github.com/apache/arrow-datafusion/pull/4037#issuecomment-1297177810
Closing this in favor of https://github.com/apache/arrow-datafusion/pull/4044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org