You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2018/05/21 06:15:28 UTC
[GitHub] zeppelin pull request #2975: ZEPPELIN-3475: Bump up version of Apache Thrift
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2975
ZEPPELIN-3475: Bump up version of Apache Thrift
### What is this PR for?
Bump up version of Apache Thrift
### What type of PR is it?
[Improvement]
### What is the Jira issue?
* [ZEPPELIN-3475](https://issues.apache.org/jira/browse/ZEPPELIN-3475)
### Questions:
* Does the licenses files need update? yes
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3475
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2975.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2975
----
commit 000e1fda2154e02ee572d518da4f703f913f2ad1
Author: Prabhjyot Singh <pr...@...>
Date: 2018-05-21T06:05:15Z
ZEPPELIN-3475: Bump up version of Apache Thrift
Change-Id: I16b5556f344c693851ca37bddb16b986151eff07
----
---
[GitHub] zeppelin issue #2975: ZEPPELIN-3475: Bump up version of Apache Thrift
Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2975
When I build Zeppelin, I see in maven build log
> [INFO] Including org.apache.thrift:libthrift:jar:0.9.3 in the shaded jar.
> [INFO] Including org.apache.thrift:libfb303:jar:0.9.3 in the shaded jar.
Does this mean it's already shaded? cc @zjffdu
---
[GitHub] zeppelin issue #2975: ZEPPELIN-3475: Bump up version of Apache Thrift
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2975
Have pushed a commit with regenerating those files with Thrift Version 0.9.3 hope this(https://github.com/apache/zeppelin/pull/2975/commits/042511df573f5d0dfb81c2970791c7ad9cb2998e#diff-b0947940a990191e771d11ab66dfb9ecR254) is now is not a concern and/or break anything.
---
[GitHub] zeppelin issue #2975: ZEPPELIN-3475: Bump up version of Apache Thrift
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2975
LGTM
---
[GitHub] zeppelin issue #2975: ZEPPELIN-3475: Bump up version of Apache Thrift
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2975
@felixcheung yes, it only affects internal uses.
Thanks for the review will merge this if no more discussion.
---
[GitHub] zeppelin issue #2975: ZEPPELIN-3475: Bump up version of Apache Thrift
Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2975
checked a few newer CDH 5 versions and they're packaged with 0.9.3.
older CDH 5 version come with 0.9.2.
CDH 6 will be shipped with 0.9.3 too.
my two cents: +1 from me.
thanks.
---
[GitHub] zeppelin issue #2975: ZEPPELIN-3475: Bump up version of Apache Thrift
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2975
hmmm - agreed maybe shade is the way to go
---
[GitHub] zeppelin issue #2975: ZEPPELIN-3475: Bump up version of Apache Thrift
Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2975
thanks @prabhjyotsingh
bumping up 0.9.3 seems a good idea to me, but I'd like somebody else to review this too.
my 2 cents - It might be also good to shade Thrift to avoid future conflicts with older/newer versions of Spark/Hive that could be relying on?
---
[GitHub] zeppelin issue #2975: ZEPPELIN-3475: Bump up version of Apache Thrift
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2975
@Tagar @felixcheung not sure if I fully understand maven-shade-plugin is this https://github.com/apache/zeppelin/pull/2975/commits/19b21b1624da552ea8168fe07919134e1a7bcb2f what we are looking for or should I do relocation-pattern/shadedPattern with all `zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/thrift/*.java`
---
[GitHub] zeppelin pull request #2975: ZEPPELIN-3475: Bump up version of Apache Thrift
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2975
---
[GitHub] zeppelin issue #2975: ZEPPELIN-3475: Bump up version of Apache Thrift
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2975
@Tagar is this because of Zeppelin's thrift@0.9.2 and Spark/Hive's thrift@0.93?
Should I also regenerate all the thrift files as well?
---
[GitHub] zeppelin issue #2975: ZEPPELIN-3475: Bump up version of Apache Thrift
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2975
@zjffdu , @r-kamath , @felixcheung can you help review this.
The variability doesn't apply to this, but this is for future accidental usage.
---
[GitHub] zeppelin issue #2975: ZEPPELIN-3475: Bump up version of Apache Thrift
Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2975
@prabhjyotsingh yes, seems that way.
It might be more specific for Cloudera or more generic.
I know that Cloudera packages CDH with a specific version of Thrift.
It used to be 0.9.2 in earlier CDH 5 versions - now it is 0.9.3 as I mentioned above.
Thanks.
---
[GitHub] zeppelin issue #2975: ZEPPELIN-3475: Bump up version of Apache Thrift
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2975
Will merge this to master (only) if no more discussion.
---
[GitHub] zeppelin issue #2975: ZEPPELIN-3475: Bump up version of Apache Thrift
Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2975
@felixcheung as an example, I've seen NoSuchMethodError exceptions like one below when working with Spark interpreter reading Hive tables and Thrift version had a version mismatch .. so it may not be as internal as it looks at first.
> Caused by: java.lang.NoSuchMethodError: com.facebook.fb303.FacebookService$Client.sendBaseOneway(Ljava/lang/String;Lorg/apache/thrift/TBase;)V
> at com.facebook.fb303.FacebookService$Client.send_shutdown(FacebookService.java:436)
> at com.facebook.fb303.FacebookService$Client.shutdown(FacebookService.java:430)
>
---