You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/15 11:50:57 UTC
[GitHub] [shardingsphere-elasticjob] luky116 opened a new pull request #1458: add EmailJobErrorHandler
luky116 opened a new pull request #1458:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1458
Fixes #1440 .
Changes proposed in this pull request:
- add EmailJobErrorHandler
-
-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #1458: add EmailJobErrorHandler
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #1458:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1458#issuecomment-692676162
The way to configure this error handler is a little strange .I don't think users who are not familiar with the source code know how to use this error hander.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN edited a comment on pull request #1458: add EmailJobErrorHandler
Posted by GitBox <gi...@apache.org>.
TeslaCN edited a comment on pull request #1458:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1458#issuecomment-692676162
The way to configure this error handler is a little strange. I don't think users who are not familiar with the source code know how to use this error hander.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] luky116 closed pull request #1458: add EmailJobErrorHandler
Posted by GitBox <gi...@apache.org>.
luky116 closed pull request #1458:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1458
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] luky116 closed pull request #1458: add EmailJobErrorHandler
Posted by GitBox <gi...@apache.org>.
luky116 closed pull request #1458:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1458
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a change in pull request #1458: add EmailJobErrorHandler
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on a change in pull request #1458:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1458#discussion_r488606305
##########
File path: elasticjob-infra/elasticjob-infra-common/src/main/java/org/apache/shardingsphere/elasticjob/infra/pojo/EmailConfigurationPOJO.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.elasticjob.infra.pojo;
+
+import lombok.Getter;
+import lombok.Setter;
+import java.nio.charset.Charset;
+
+/**
+ * Job configuration POJO.
+ */
+@Getter
+@Setter
+public final class EmailConfigurationPOJO {
+
+ private String host;
+
+ private Integer port;
+
+ private String username;
+
+ private String password;
+
+ private String protocol = "smtp";
+
+ private Charset encoding = Charset.forName("UTF-8");
Review comment:
Maybe using java.nio.charset.StandardCharsets.UTF_8 is better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] Technoboy- commented on a change in pull request #1458: add EmailJobErrorHandler
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #1458:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1458#discussion_r488622799
##########
File path: elasticjob-infra/elasticjob-infra-common/src/main/java/org/apache/shardingsphere/elasticjob/infra/pojo/EmailConfigurationPOJO.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.elasticjob.infra.pojo;
+
+import lombok.Getter;
+import lombok.Setter;
+import java.nio.charset.Charset;
+
+/**
+ * Job configuration POJO.
+ */
+@Getter
+@Setter
+public final class EmailConfigurationPOJO {
+
+ private String host;
+
+ private Integer port;
+
+ private String username;
+
+ private String password;
+
+ private String protocol = "smtp";
+
+ private Charset encoding = Charset.forName("UTF-8");
Review comment:
Yes, name it UTF_8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] luky116 commented on pull request #1458: add EmailJobErrorHandler
Posted by GitBox <gi...@apache.org>.
luky116 commented on pull request #1458:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1458#issuecomment-692683430
> Forget to submit the SPI service
i will do this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN removed a comment on pull request #1458: add EmailJobErrorHandler
Posted by GitBox <gi...@apache.org>.
TeslaCN removed a comment on pull request #1458:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1458#issuecomment-692676162
The way to configure this error handler is a little strange. I don't think users who are not familiar with the source code know how to use this error hander.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #1458: add EmailJobErrorHandler
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #1458:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1458#issuecomment-692682022
> The way to configure this error handler is a little strange. I don't think users who are not familiar with the source code know how to use this error handler.
Consider using system properties or environment variables?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] luky116 commented on a change in pull request #1458: add EmailJobErrorHandler
Posted by GitBox <gi...@apache.org>.
luky116 commented on a change in pull request #1458:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1458#discussion_r488627167
##########
File path: elasticjob-infra/elasticjob-infra-common/src/main/java/org/apache/shardingsphere/elasticjob/infra/pojo/EmailConfigurationPOJO.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.elasticjob.infra.pojo;
+
+import lombok.Getter;
+import lombok.Setter;
+import java.nio.charset.Charset;
+
+/**
+ * Job configuration POJO.
+ */
+@Getter
+@Setter
+public final class EmailConfigurationPOJO {
+
+ private String host;
+
+ private Integer port;
+
+ private String username;
+
+ private String password;
+
+ private String protocol = "smtp";
+
+ private Charset encoding = Charset.forName("UTF-8");
Review comment:
I'll try this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org