You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by Vinod Kone <vi...@gmail.com> on 2015/06/01 20:31:55 UTC

Re: Review Request 34484: Daemonize all deadline calls in aurora executor.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34484/#review86035
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On May 26, 2015, 8:43 p.m., Brian Wickman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34484/
> -----------------------------------------------------------
> 
> (Updated May 26, 2015, 8:43 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Vinod Kone.
> 
> 
> Bugs: AURORA-698
>     https://issues.apache.org/jira/browse/AURORA-698
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Daemonize all deadline calls in aurora executor.  If we do not daemonize, it's possible for the aurora executor to send TASK_KILLED and then block indefinitely on shutdown.  This way the aurora executor process will at least exit, allow the cgroup to tear down all active processes.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py df0df0cba3269a137a370e2b4096fd61fd3af258 
> 
> Diff: https://reviews.apache.org/r/34484/diff/
> 
> 
> Testing
> -------
> 
> ./pants test src/test/python/apache/aurora/executor::
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>