[GitHub] [doris] HappenLee commented on a diff in pull request #18682: [BugFix](functions) fix multi_search_all_positions

["HappenLee (via GitHub)" <gi...@apache.org>]

HappenLee commented on code in PR #18682:
URL: https://github.com/apache/doris/pull/18682#discussion_r1166655674


##########
be/src/vec/functions/functions_multi_string_position.cpp:
##########
@@ -103,8 +105,19 @@ class FunctionMultiStringPosition : public IFunction {
     }
 };
 
-template <typename Impl>
 struct FunctionMultiSearchAllPositionsImpl {
+private:
+    using SingleSearcher = ASCIICaseSensitiveStringSearcher;
+    static SingleSearcher create_multi_searcher(const StringRef& needle) {

Review Comment:
   only use in `FunctionMultiSearchAllPositionsImpl ` do not need static



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org