You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "TSultanov (via GitHub)" <gi...@apache.org> on 2023/03/17 16:45:15 UTC

[GitHub] [beam] TSultanov opened a new pull request, #25884: Refactor playground/terraform gradle file to use only Gradle plugin

TSultanov opened a new pull request, #25884:
URL: https://github.com/apache/beam/pull/25884

   Removed all exec{} blocks which relied on system-installed terraform and replaced them with TerraformTask derivatives
   
   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] MakarkinSAkvelon commented on pull request #25884: Remove exec calls to terraform from playground/terraform/build.gradle.kts

Posted by "MakarkinSAkvelon (via GitHub)" <gi...@apache.org>.
MakarkinSAkvelon commented on PR #25884:
URL: https://github.com/apache/beam/pull/25884#issuecomment-1476422311

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] TSultanov commented on a diff in pull request #25884: Remove exec calls to terraform from playground/terraform/build.gradle.kts

Posted by "TSultanov (via GitHub)" <gi...@apache.org>.
TSultanov commented on code in PR #25884:
URL: https://github.com/apache/beam/pull/25884#discussion_r1149306465


##########
playground/terraform/build.gradle.kts:
##########
@@ -247,24 +247,6 @@ tasks {
     }
 }
 
-/* set Docker Registry to params from Inf */
-tasks.register("setDockerRegistry") {

Review Comment:
   We use, but we are expecting that it will be passed through the command line. The issue is that this value is used by the Gradle before we can reliably read it from terraform configuration.
   For example, [this](https://github.com/apache/beam/blob/f333e0f8cd3a3771c0d8ce703fdf857ca2fa83c7/playground/backend/containers/python/build.gradle#L76) line will be evaluated before any of the tasks are executed. We can be reading terraform in the gradle configuration phase, but it's not reliable as there is no way to define the order in which dependencies are evaluated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #25884: Remove exec calls to terraform from playground/terraform/build.gradle.kts

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #25884:
URL: https://github.com/apache/beam/pull/25884#discussion_r1149267752


##########
playground/terraform/build.gradle.kts:
##########
@@ -247,24 +247,6 @@ tasks {
     }
 }
 
-/* set Docker Registry to params from Inf */
-tasks.register("setDockerRegistry") {

Review Comment:
   Why don't we need this anymore? Don't we use `docker-repository-root` below?



##########
playground/terraform/build.gradle.kts:
##########
@@ -363,140 +338,153 @@ tasks.register("deployFrontend") {
     dependsOn(deploy)
 }
 
-/* build, push, deploy Backend app */
-tasks.register("deployBackend") {
+tasks.register<TerraformTask>("setPlaygroundStaticIpAddress") {
     group = "deploy"
-    description = "deploy Backend app"
-    //TODO please add default tag from project_environment property
-    //if !(project.hasProperty("docker-tag")) {
-    //    project.extra.set("docker-tag", project.property("project_environment") as String)
-    //}
-    val config = tasks.getByName("setDockerRegistry")
-    val push = tasks.getByName("pushBack")
-    val deploy = tasks.getByName("terraformApplyAppBack")

Review Comment:
   Why don't we need to do this task anymore?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] TSultanov commented on a diff in pull request #25884: Remove exec calls to terraform from playground/terraform/build.gradle.kts

Posted by "TSultanov (via GitHub)" <gi...@apache.org>.
TSultanov commented on code in PR #25884:
URL: https://github.com/apache/beam/pull/25884#discussion_r1149308186


##########
playground/terraform/build.gradle.kts:
##########
@@ -363,140 +338,153 @@ tasks.register("deployFrontend") {
     dependsOn(deploy)
 }
 
-/* build, push, deploy Backend app */
-tasks.register("deployBackend") {
+tasks.register<TerraformTask>("setPlaygroundStaticIpAddress") {
     group = "deploy"
-    description = "deploy Backend app"
-    //TODO please add default tag from project_environment property
-    //if !(project.hasProperty("docker-tag")) {
-    //    project.extra.set("docker-tag", project.property("project_environment") as String)
-    //}
-    val config = tasks.getByName("setDockerRegistry")
-    val push = tasks.getByName("pushBack")
-    val deploy = tasks.getByName("terraformApplyAppBack")

Review Comment:
   It was replaced by `gkebackend` task and not used anywhere



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm merged pull request #25884: Remove exec calls to terraform from playground/terraform/build.gradle.kts

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #25884:
URL: https://github.com/apache/beam/pull/25884


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org