You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by mb...@apache.org on 2016/10/22 00:07:28 UTC
[1/3] hbase git commit: HBASE-16815 Low scan ratio in RPC queue
tuning triggers divide by zero exception
Repository: hbase
Updated Branches:
refs/heads/branch-1 9fda0dd09 -> e395bf91d
refs/heads/branch-1.2 fdb921c89 -> 5526c9470
refs/heads/master 4983c742e -> 641513757
HBASE-16815 Low scan ratio in RPC queue tuning triggers divide by zero exception
Signed-off-by: Matteo Bertozzi <ma...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/64151375
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/64151375
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/64151375
Branch: refs/heads/master
Commit: 641513757496842c7077ab5c46618a892768d14c
Parents: 4983c74
Author: Guanghao Zhang <zg...@gmail.com>
Authored: Fri Oct 14 18:29:25 2016 +0800
Committer: Matteo Bertozzi <ma...@cloudera.com>
Committed: Fri Oct 21 16:59:55 2016 -0700
----------------------------------------------------------------------
.../apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/64151375/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
index 333569a..78c1a52 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
@@ -146,17 +146,16 @@ public class RWQueueRpcExecutor extends RpcExecutor {
this.scanBalancer = numScanQueues > 0 ? getBalancer(numScanQueues) : null;
queues = new ArrayList<BlockingQueue<CallRunner>>(numWriteQueues + numReadQueues + numScanQueues);
- LOG.debug(name + " writeQueues=" + numWriteQueues + " writeHandlers=" + writeHandlersCount +
- " readQueues=" + numReadQueues + " readHandlers=" + readHandlersCount +
- ((numScanQueues == 0) ? "" : " scanQueues=" + numScanQueues +
- " scanHandlers=" + scanHandlersCount));
+ LOG.info(name + " writeQueues=" + numWriteQueues + " writeHandlers=" + writeHandlersCount
+ + " readQueues=" + numReadQueues + " readHandlers=" + readHandlersCount + " scanQueues="
+ + numScanQueues + " scanHandlers=" + scanHandlersCount);
+
if (writeQueueInitArgs.length > 0) {
currentQueueLimit = (int) writeQueueInitArgs[0];
writeQueueInitArgs[0] = Math.max((int) writeQueueInitArgs[0],
DEFAULT_CALL_QUEUE_SIZE_HARD_LIMIT);
}
for (int i = 0; i < numWriteQueues; ++i) {
-
queues.add((BlockingQueue<CallRunner>)
ReflectionUtils.newInstance(writeQueueClass, writeQueueInitArgs));
}
@@ -176,8 +175,10 @@ public class RWQueueRpcExecutor extends RpcExecutor {
protected void startHandlers(final int port) {
startHandlers(".write", writeHandlersCount, queues, 0, numWriteQueues, port);
startHandlers(".read", readHandlersCount, queues, numWriteQueues, numReadQueues, port);
- startHandlers(".scan", scanHandlersCount, queues,
- numWriteQueues + numReadQueues, numScanQueues, port);
+ if (numScanQueues > 0) {
+ startHandlers(".scan", scanHandlersCount, queues, numWriteQueues + numReadQueues,
+ numScanQueues, port);
+ }
}
@Override
[3/3] hbase git commit: HBASE-16815 Low scan ratio in RPC queue
tuning triggers divide by zero exception
Posted by mb...@apache.org.
HBASE-16815 Low scan ratio in RPC queue tuning triggers divide by zero exception
Signed-off-by: Matteo Bertozzi <ma...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/5526c947
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/5526c947
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/5526c947
Branch: refs/heads/branch-1.2
Commit: 5526c947082ce37e93f0a6c330e6828f2fadaede
Parents: fdb921c
Author: Guanghao Zhang <zg...@gmail.com>
Authored: Mon Oct 17 09:25:51 2016 +0800
Committer: Matteo Bertozzi <ma...@cloudera.com>
Committed: Fri Oct 21 17:04:08 2016 -0700
----------------------------------------------------------------------
.../apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/5526c947/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
index de4b4de..60254c6 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
@@ -135,10 +135,9 @@ public class RWQueueRpcExecutor extends RpcExecutor {
this.scanBalancer = getBalancer(numScanQueues);
queues = new ArrayList<BlockingQueue<CallRunner>>(writeHandlersCount + readHandlersCount);
- LOG.debug(name + " writeQueues=" + numWriteQueues + " writeHandlers=" + writeHandlersCount +
- " readQueues=" + numReadQueues + " readHandlers=" + readHandlersCount +
- ((numScanQueues == 0) ? "" : " scanQueues=" + numScanQueues +
- " scanHandlers=" + scanHandlersCount));
+ LOG.info(name + " writeQueues=" + numWriteQueues + " writeHandlers=" + writeHandlersCount
+ + " readQueues=" + numReadQueues + " readHandlers=" + readHandlersCount + " scanQueues="
+ + numScanQueues + " scanHandlers=" + scanHandlersCount);
for (int i = 0; i < numWriteQueues; ++i) {
queues.add((BlockingQueue<CallRunner>)
@@ -155,8 +154,10 @@ public class RWQueueRpcExecutor extends RpcExecutor {
protected void startHandlers(final int port) {
startHandlers(".write", writeHandlersCount, queues, 0, numWriteQueues, port);
startHandlers(".read", readHandlersCount, queues, numWriteQueues, numReadQueues, port);
- startHandlers(".scan", scanHandlersCount, queues,
- numWriteQueues + numReadQueues, numScanQueues, port);
+ if (numScanQueues > 0) {
+ startHandlers(".scan", scanHandlersCount, queues, numWriteQueues + numReadQueues,
+ numScanQueues, port);
+ }
}
@Override
[2/3] hbase git commit: HBASE-16815 Low scan ratio in RPC queue
tuning triggers divide by zero exception
Posted by mb...@apache.org.
HBASE-16815 Low scan ratio in RPC queue tuning triggers divide by zero exception
Signed-off-by: Matteo Bertozzi <ma...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/e395bf91
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/e395bf91
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/e395bf91
Branch: refs/heads/branch-1
Commit: e395bf91dbafc7d892966122972e70c5446f3a09
Parents: 9fda0dd
Author: Guanghao Zhang <zg...@gmail.com>
Authored: Fri Oct 14 18:29:25 2016 +0800
Committer: Matteo Bertozzi <ma...@cloudera.com>
Committed: Fri Oct 21 17:00:24 2016 -0700
----------------------------------------------------------------------
.../apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/e395bf91/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
index 68e7b65..7ca9196 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RWQueueRpcExecutor.java
@@ -145,17 +145,16 @@ public class RWQueueRpcExecutor extends RpcExecutor {
this.scanBalancer = numScanQueues > 0 ? getBalancer(numScanQueues) : null;
queues = new ArrayList<BlockingQueue<CallRunner>>(numWriteQueues + numReadQueues + numScanQueues);
- LOG.debug(name + " writeQueues=" + numWriteQueues + " writeHandlers=" + writeHandlersCount +
- " readQueues=" + numReadQueues + " readHandlers=" + readHandlersCount +
- ((numScanQueues == 0) ? "" : " scanQueues=" + numScanQueues +
- " scanHandlers=" + scanHandlersCount));
+ LOG.info(name + " writeQueues=" + numWriteQueues + " writeHandlers=" + writeHandlersCount
+ + " readQueues=" + numReadQueues + " readHandlers=" + readHandlersCount + " scanQueues="
+ + numScanQueues + " scanHandlers=" + scanHandlersCount);
+
if (writeQueueInitArgs.length > 0) {
currentQueueLimit = (int) writeQueueInitArgs[0];
writeQueueInitArgs[0] = Math.max((int) writeQueueInitArgs[0],
DEFAULT_CALL_QUEUE_SIZE_HARD_LIMIT);
}
for (int i = 0; i < numWriteQueues; ++i) {
-
queues.add((BlockingQueue<CallRunner>)
ReflectionUtils.newInstance(writeQueueClass, writeQueueInitArgs));
}
@@ -175,8 +174,10 @@ public class RWQueueRpcExecutor extends RpcExecutor {
protected void startHandlers(final int port) {
startHandlers(".write", writeHandlersCount, queues, 0, numWriteQueues, port);
startHandlers(".read", readHandlersCount, queues, numWriteQueues, numReadQueues, port);
- startHandlers(".scan", scanHandlersCount, queues,
- numWriteQueues + numReadQueues, numScanQueues, port);
+ if (numScanQueues > 0) {
+ startHandlers(".scan", scanHandlersCount, queues, numWriteQueues + numReadQueues,
+ numScanQueues, port);
+ }
}
@Override